[Password manager tests automation] Fixes buzzfeed test.

components/test/data/password_manager/automated_tests/websitetest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """WebsiteTest testing class."""
 
 import logging
 import time
 
 from selenium.webdriver.common.action_chains import ActionChains
@@ skipping 12 matching lines @@
   """
 
   # Possible values of self.autofill_expectation.
   AUTOFILLED = 1  # Expect password and username to be autofilled.
   NOT_AUTOFILLED = 2  # Expect password and username not to be autofilled.
 
   # The maximal accumulated time to spend in waiting for website UI
   # interaction.
   MAX_WAIT_TIME_IN_SECONDS = 200
 
-  def __init__(self, name, username_not_auto=False):
+  def __init__(self, name, username_not_auto=False, password_not_auto=True):

[vabr (Chromium), 2015/05/18 16:13:34]

Should the default value be False?

[melandory, 2015/05/19 08:06:34]

Done.

     """Creates a new WebsiteTest.
 
     Args:
       name: The website name, identifying it in the test results.
       username_not_auto: Expect that the tested website fills username field
         on load, and Chrome cannot autofill in that case.
+      password_not_auto: Expect that the tested website fills password field
+        on load, and Chrome cannot autofill in that case.
     """
     self.name = name
     self.username = None
     self.password = None
     self.username_not_auto = username_not_auto
+    self.password_not_auto = password_not_auto
 
     # Specify, whether it is expected that credentials get autofilled.
     self.autofill_expectation = WebsiteTest.NOT_AUTOFILLED
     self.remaining_seconds_to_wait = WebsiteTest.MAX_WAIT_TIME_IN_SECONDS
     # The testing Environment, if added to any.
     self.environment = None
     # The webdriver from the environment.
     self.driver = None
 
   # Mouse/Keyboard actions.
@@ skipping 133 matching lines @@
       element = self._ReturnElementIfDisplayed(selector)
     return element
 
   # Form actions.
 
   def FillPasswordInto(self, selector):
     """Ensures that the selected element's value is the saved password.
 
     Depending on self.autofill_expectation, this either checks that the
     element already has the password autofilled, or checks that the value
-    is empty and replaces it with the password.
+    is empty and replaces it with the password. If self.password_not_auto
+    is true, it skips the checks and just overwrites the value with the
+    password.
 
     Args:
       selector: The CSS selector for the filled element.
 
     Raises:
       Exception: An exception is raised if the element's value is different
           from the expectation.
     """
 
     logging.log(SCRIPT_DEBUG, "action: FillPasswordInto %s" % selector)
     password_element = self.WaitUntilDisplayed(selector)
 
     # Chrome protects the password inputs and doesn't fill them until
     # the user interacts with the page. To be sure that such thing has
     # happened we perform |Keys.CONTROL| keypress.
     action_chains = ActionChains(self.driver)
     action_chains.key_down(Keys.CONTROL).key_up(Keys.CONTROL).perform()
 
     self.Wait(2)  # TODO(vabr): Detect when autofill finished.
-    if self.autofill_expectation == WebsiteTest.AUTOFILLED:
-      if password_element.get_attribute("value") != self.password:
-        raise Exception("Error: autofilled password is different from the saved"
-                        " one on website: %s" % self.name)
-    elif self.autofill_expectation == WebsiteTest.NOT_AUTOFILLED:
-      if password_element.get_attribute("value"):
-        raise Exception("Error: password value unexpectedly not empty on"
-                        "website: %s" % self.name)
-      password_element.send_keys(self.password)
+    if not self.password_not_auto:
+      if self.autofill_expectation == WebsiteTest.AUTOFILLED:
+        if password_element.get_attribute("value") != self.password:
+          raise Exception("Error: autofilled password is different from the"
+                          "saved one on website: %s" % self.name)
+      elif self.autofill_expectation == WebsiteTest.NOT_AUTOFILLED:
+        if password_element.get_attribute("value"):
+          raise Exception("Error: password value unexpectedly not empty on"
+                          "website: %s" % self.name)
+
+    password_element.clear()
+    password_element.send_keys(self.password)
 
   def FillUsernameInto(self, selector):
     """Ensures that the selected element's value is the saved username.
 
     Depending on self.autofill_expectation, this either checks that the
     element already has the username autofilled, or checks that the value
     is empty and replaces it with the password. If self.username_not_auto
     is true, it skips the checks and just overwrites the value with the
     username.
 
@@ skipping 119 matching lines @@
         [environment.MESSAGE_SAVE],
         True,
         "Error: did not detect login success on website: %s" % self.name)
     self.Logout()
     self.LoginWhenAutofilled()
     self.environment.CheckForNewString(
         [environment.MESSAGE_SAVE],
         True,
         "Error: failed autofilled login on website: %s" % self.name)