Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 1138343003: Only update icon if the new one is not null. (Closed)

Created:
5 years, 7 months ago by xiaoling
Modified:
5 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only update icon if the new one is not null on x11, no-op for null icon (follow the same way as Windows platform does in HWNDMessageHandler::SetWindowIcons) BUG=478714 . Committed: https://crrev.com/eb6d82cd81c4e0a4dc528e98630283b17e17e2d9 Cr-Commit-Position: refs/heads/master@{#329704}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xiaoling
5 years, 7 months ago (2015-05-13 19:21:34 UTC) #2
Elliot Glaysher
lgtm
5 years, 7 months ago (2015-05-13 19:52:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138343003/20001
5 years, 7 months ago (2015-05-13 20:06:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 20:09:48 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 20:10:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb6d82cd81c4e0a4dc528e98630283b17e17e2d9
Cr-Commit-Position: refs/heads/master@{#329704}

Powered by Google App Engine
This is Rietveld 408576698