Layout Tests for client attribute of Fetchvent

Layout Tests for client attribute of Fetchvent

Intent to Implement and Ship Link: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/fetchevent/blink-dev/naYY_V77Amo/zd4v_jwWlvsJ

[PATCH 1]: Blink Side: https://codereview.chromium.org/1102363002/
[Patch 2]: Chromium Side: https://codereview.chromium.org/1108273002/
[Patch 3]: Layout Tests: This Patch.

BUG=470036

[Paritosh Kumar, 2015-05-12 12:20:42]

paritosh.in@samsung.com changed reviewers:
+ falken@chromium.org, jsbell@chromium.org

[Paritosh Kumar, 2015-05-12 12:20:43]

Now tests are here please have a look.

https://codereview.chromium.org/1138223002/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html
(right):

https://codereview.chromium.org/1138223002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html:18:
'nested', 'frameType for frame should be nested');
Yes, this will be nested for frame.

[jsbell, 2015-05-12 16:42:47]

lgtm

[falken, 2015-05-15 04:41:25]

lgtm

https://codereview.chromium.org/1138223002/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html
(right):

https://codereview.chromium.org/1138223002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html:18:
'nested', 'frameType for frame should be nested');
nit: this line should be indented so the arguments line up.

assert_equals(frame.contentDocument.body.textContent,
                      'nested', 'frameType for frame should be nested');

[Paritosh Kumar, 2015-05-15 05:46:32]

Thanks falken

https://codereview.chromium.org/1138223002/diff/20001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html
(right):

https://codereview.chromium.org/1138223002/diff/20001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html:18:
'nested', 'frameType for frame should be nested');
On 2015/05/15 04:41:25, falken wrote:
> nit: this line should be indented so the arguments line up.
> 
> assert_equals(frame.contentDocument.body.textContent,
>                       'nested', 'frameType for frame should be nested');

Done. Thanks.

[Paritosh Kumar, 2015-07-22 03:56:48]

On 2015/05/15 05:46:32, Paritosh Kumar wrote:
> Thanks falken
> 
>
https://codereview.chromium.org/1138223002/diff/20001/LayoutTests/http/tests/...
> File LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html
> (right):
> 
>
https://codereview.chromium.org/1138223002/diff/20001/LayoutTests/http/tests/...
> LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html:18:
> 'nested', 'frameType for frame should be nested');
> On 2015/05/15 04:41:25, falken wrote:
> > nit: this line should be indented so the arguments line up.
> > 
> > assert_equals(frame.contentDocument.body.textContent,
> >                       'nested', 'frameType for frame should be nested');
> 
> Done. Thanks.

As client attribute removed from specs,
https://github.com/slightlyoff/ServiceWorker/issues/723
this test is not required. Closing.