Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 1138163002: Passing scoped_ptr into ScopedVector (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, vabr (Chromium), miu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Substituting pattern push_back(ptr.release()) with push_back(ptr.Pass()) in media/ BUG=457697 Committed: https://crrev.com/04591163c31819c50d1ad762072979c5785b15bf Cr-Commit-Position: refs/heads/master@{#329592}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed file as suggested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M media/audio/audio_input_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/external_video_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager_usb.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-05-12 09:19:53 UTC) #2
xhwang
lgtm % one comment https://codereview.chromium.org/1138163002/diff/1/media/base/audio_block_fifo.cc File media/base/audio_block_fifo.cc (right): https://codereview.chromium.org/1138163002/diff/1/media/base/audio_block_fifo.cc#newcode97 media/base/audio_block_fifo.cc:97: AudioBus::Create(channels_, block_frames_).Pass()); .Pass() not needed?
5 years, 7 months ago (2015-05-12 16:13:06 UTC) #3
anujsharma
Thanks xhwang for your review and lgtm. I will remove the said change in the ...
5 years, 7 months ago (2015-05-13 03:01:07 UTC) #4
anujsharma
@Xhwang I have removed the change from "media/base/audio_block_fifo.cc" file. I am now proceeding to commit. ...
5 years, 7 months ago (2015-05-13 03:20:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138163002/20001
5 years, 7 months ago (2015-05-13 03:21:11 UTC) #8
anujsharma
@xhwang I have checked with the builds, everything going well. So, could you please give ...
5 years, 7 months ago (2015-05-13 04:42:49 UTC) #10
xhwang
lgtm LGTM
5 years, 7 months ago (2015-05-13 05:51:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138163002/20001
5 years, 7 months ago (2015-05-13 05:52:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 05:55:46 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 05:56:33 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04591163c31819c50d1ad762072979c5785b15bf
Cr-Commit-Position: refs/heads/master@{#329592}

Powered by Google App Engine
This is Rietveld 408576698