media/cast/sender/external_video_encoder.cc - Issue 1138163002: Passing scoped_ptr into ScopedVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/sender/external_video_encoder.cc

Issue 1138163002: Passing scoped_ptr into ScopedVector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed file as suggested Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/sender/external_video_encoder.cc

diff --git a/media/cast/sender/external_video_encoder.cc b/media/cast/sender/external_video_encoder.cc

index a49cb9120a62ee2d49821184de20e8b3343f60ad..95f2fb08a12e1a853566d68a380adce825369dd7 100644

--- a/media/cast/sender/external_video_encoder.cc

+++ b/media/cast/sender/external_video_encoder.cc

@@ -269,7 +269,7 @@ class ExternalVideoEncoder::VEAClientImpl

void OnReceivedSharedMemory(scoped_ptr<base::SharedMemory> memory) {

DCHECK(task_runner_->RunsTasksOnCurrentThread());

- output_buffers_.push_back(memory.release());

+ output_buffers_.push_back(memory.Pass());

// Wait until all requested buffers are received.

if (output_buffers_.size() < kOutputBufferCount)

« no previous file with comments | « media/audio/audio_input_device.cc ('k') | media/midi/midi_manager_usb.cc » ('j') | no next file with comments »