Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138013005: Lots of small fixes to help wire things together for the 0.8 upgrade. (Closed)

Created:
5 years, 7 months ago by Jeremy Klein
Modified:
5 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lots of small fixes to help wire things together for the 0.8 upgrade. BUG=485381 Committed: https://crrev.com/6aa40b6cc5150279b50a91cbdb447618191cefdc Cr-Commit-Position: refs/heads/master@{#329733}

Patch Set 1 #

Patch Set 2 : Lots of small fixes to help wire things together for the 0.8 upgrade. #

Total comments: 4

Patch Set 3 : remove undefined observer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M chrome/browser/resources/md_settings/md_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/prefs/prefs.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engines_page.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 2 chunks +4 lines, -14 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 2 4 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Jeremy Klein
5 years, 7 months ago (2015-05-13 19:32:09 UTC) #2
Jeremy Klein
5 years, 7 months ago (2015-05-13 19:32:11 UTC) #3
michaelpg
lgtm https://codereview.chromium.org/1138013005/diff/20001/chrome/browser/resources/settings/prefs/prefs.js File chrome/browser/resources/settings/prefs/prefs.js (right): https://codereview.chromium.org/1138013005/diff/20001/chrome/browser/resources/settings/prefs/prefs.js#newcode93 chrome/browser/resources/settings/prefs/prefs.js:93: // ObjectObserver fires. is this logic still valid, ...
5 years, 7 months ago (2015-05-13 19:38:31 UTC) #4
michaelpg
https://codereview.chromium.org/1138013005/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js File chrome/browser/resources/settings/settings_main/settings_main.js (right): https://codereview.chromium.org/1138013005/diff/20001/chrome/browser/resources/settings/settings_main/settings_main.js#newcode42 chrome/browser/resources/settings/settings_main/settings_main.js:42: observer: 'pagesChanged_', pagesChanged_ is undefined?
5 years, 7 months ago (2015-05-13 19:59:19 UTC) #5
Jeremy Klein
https://codereview.chromium.org/1138013005/diff/20001/chrome/browser/resources/settings/prefs/prefs.js File chrome/browser/resources/settings/prefs/prefs.js (right): https://codereview.chromium.org/1138013005/diff/20001/chrome/browser/resources/settings/prefs/prefs.js#newcode93 chrome/browser/resources/settings/prefs/prefs.js:93: // ObjectObserver fires. On 2015/05/13 19:38:30, michaelpg wrote: > ...
5 years, 7 months ago (2015-05-13 21:13:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138013005/40001
5 years, 7 months ago (2015-05-13 21:16:15 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 22:16:32 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 22:17:22 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6aa40b6cc5150279b50a91cbdb447618191cefdc
Cr-Commit-Position: refs/heads/master@{#329733}

Powered by Google App Engine
This is Rietveld 408576698