chrome/browser/resources/settings/prefs/prefs.js - Issue 1138013005: Lots of small fixes to help wire things together for the 0.8 upgrade.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/prefs/prefs.js

Issue 1138013005: Lots of small fixes to help wire things together for the 0.8 upgrade. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove undefined observer Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_settings/md_settings.html ('k') | chrome/browser/resources/settings/search_engines_page/search_engines_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/prefs/prefs.js

diff --git a/chrome/browser/resources/settings/prefs/prefs.js b/chrome/browser/resources/settings/prefs/prefs.js

index 8cc30493e91f29f742b54ebdc4788842843a1d62..4ad71288833ea9cc15e8e5261e48991773e51f84 100644

--- a/chrome/browser/resources/settings/prefs/prefs.js

+++ b/chrome/browser/resources/settings/prefs/prefs.js

@@ -83,7 +83,8 @@

let token = tokens[i];

if (!root.hasOwnProperty(token)) {

- root[token] = {};

+ let path = 'settings.' + tokens.slice(0, i + 1).join('.');

+ this.setPathValue(path, {});

}

root = root[token];

}

@@ -91,7 +92,8 @@

// NOTE: Do this copy rather than just a re-assignment, so that the

// ObjectObserver fires.

for (let objKey in prefObj) {

- root[objKey] = prefObj[objKey];

+ let path = 'settings.' + prefObj.key + '.' + objKey;

+ this.setPathValue(path, prefObj[objKey]);

}

if (shouldObserve) {