Issue 1137833004: Devtools Animations: Update timeline reset condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1137833004: Devtools Animations: Update timeline reset condition (Closed)

Created:
5 years, 7 months ago by samli

Modified:
5 years, 7 months ago

Reviewers:
pfeldman

CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dstockwell, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, Mike Lawther (Google), pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans, Steve Block, Timothy Loh, yurys+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Devtools Animations: Update timeline reset condition Instead of iterating over all animations each time a new animaiton is created, store the latest start time which determines the reset condition. BUG=447083 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195497

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	Source/core/inspector/InspectorAnimationAgent.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/core/inspector/InspectorAnimationAgent.cpp	View		2 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137833004/1

5 years, 7 months ago (2015-05-18 23:56:34 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 01:21:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195497

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages