Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1137773003: Tests that the title only ever gets replaced for the current page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 2e6a5f7556dd8378d2b796a9d676fa9c9ce0472c..51c78e331ab2bda495483c0947ab92519bdbd33d 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3868,6 +3868,11 @@ void WebContentsImpl::UpdateTitle(RenderFrameHost* render_frame_host,
NavigationEntryImpl* entry = controller_.GetEntryWithPageID(
rvh->GetSiteInstance(), page_id);
+ // Re http://crbug.com/369661, page id is going away. This function should
+ // only ever be called for the current entry. When this is verified, this
+ // function can be greatly simplified.
+ CHECK_EQ(entry, controller_.GetEntryAtOffset(0));
Charlie Reis 2015/05/11 20:32:38 Interesting that this passed. Would it fail if we
Avi (use Gerrit) 2015/05/11 20:52:46 Dunno! Let's find out.
+
// We can handle title updates when we don't have an entry in
// UpdateTitleForEntry, but only if the update is from the current RVH.
// TODO(avi): Change to make decisions based on the RenderFrameHost.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698