Tests that the title only ever gets replaced for the current page.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 3850 matching lines @@
 
   // If we have a title, that's a pretty good indication that we've started
   // getting useful data.
   SetNotWaitingForResponse();
 
   // Try to find the navigation entry, which might not be the current one.
   // For example, it might be from a pending RVH for the pending entry.
   NavigationEntryImpl* entry = controller_.GetEntryWithPageID(
       rvh->GetSiteInstance(), page_id);
 
+  // Re http://crbug.com/369661, page id is going away. This function should
+  // only ever be called for the current entry. When this is verified, this
+  // function can be greatly simplified.
+  CHECK_EQ(entry, controller_.GetEntryAtOffset(0));

[Charlie Reis, 2015/05/11 20:32:38]

Interesting that this passed.  Would it fail if we used GetLastCommittedEntry,
as in https://codereview.chromium.org/1135853002/?  I'd prefer to use the last
committed entry for this if it works, but we can comment why it must be the
current (pending/transient) if that's needed.

[Avi (use Gerrit), 2015/05/11 20:52:46]

Dunno! Let's find out.

+
   // We can handle title updates when we don't have an entry in
   // UpdateTitleForEntry, but only if the update is from the current RVH.
   // TODO(avi): Change to make decisions based on the RenderFrameHost.
   if (!entry && rvh != GetRenderViewHost())
     return;
 
   // TODO(evan): make use of title_direction.
   // http://code.google.com/p/chromium/issues/detail?id=27094
   if (!UpdateTitleForEntry(entry, title))
     return;
@@ skipping 548 matching lines @@
   node->render_manager()->ResumeResponseDeferredAtStart();
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
 }  // namespace content