Tests that the title only ever gets replaced for the current page.

Tests that the title only ever gets replaced for the current page.

BUG=369661
TEST=All tests remain green.

Committed: https://crrev.com/e5fab09f6e313f78d4113e4d4fe0ce3b38ce0ca5
Cr-Commit-Position: refs/heads/master@{#329414}

[Avi (use Gerrit), 2015-05-08 23:37:11]

avi@chromium.org changed reviewers:
+ creis@chromium.org

[Avi (use Gerrit), 2015-05-08 23:37:11]

Before we were testing that the page id from the renderer matched our notion of
page id in the browser. Now we try to remove it altogether.

I love user experimentation.

[Charlie Reis, 2015-05-11 20:32:38]

https://codereview.chromium.org/1137773003/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/1137773003/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_impl.cc:3874: CHECK_EQ(entry,
controller_.GetEntryAtOffset(0));
Interesting that this passed.  Would it fail if we used GetLastCommittedEntry,
as in https://codereview.chromium.org/1135853002/?  I'd prefer to use the last
committed entry for this if it works, but we can comment why it must be the
current (pending/transient) if that's needed.

[Avi (use Gerrit), 2015-05-11 20:52:46]

https://codereview.chromium.org/1137773003/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/1137773003/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_impl.cc:3874: CHECK_EQ(entry,
controller_.GetEntryAtOffset(0));
On 2015/05/11 20:32:38, Charlie Reis wrote:
> Interesting that this passed.  Would it fail if we used GetLastCommittedEntry,
> as in https://codereview.chromium.org/1135853002/  I'd prefer to use the last
> committed entry for this if it works, but we can comment why it must be the
> current (pending/transient) if that's needed.

Dunno! Let's find out.

[Avi (use Gerrit), 2015-05-12 00:39:58]

Well, look at that! PTAL.

[Charlie Reis, 2015-05-12 16:08:55]

Great.  LGTM.

[Avi (use Gerrit), 2015-05-12 16:10:19]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-05-12 16:10:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137773003/20001

[commit-bot: I haz the power, 2015-05-12 16:15:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-12 16:16:58]

Patchset 2 (id:??) landed as
https://crrev.com/e5fab09f6e313f78d4113e4d4fe0ce3b38ce0ca5
Cr-Commit-Position: refs/heads/master@{#329414}

[Avi (use Gerrit), 2015-05-13 18:49:04]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1144443005/ by avi@chromium.org.

The reason for reverting is: We're seeing crashes; this looks to be the wrong
approach..