Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137753003: Merge to XFA: Better error from pdfium_test when page too big to render. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Better error from pdfium_test when page too big to render. Original Review URL: https://codereview.chromium.org/1124423006 BUG=pdfium:114 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bad79b3b02c9c56cf4eef436116bc9ad1bfb65b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M fpdfsdk/src/fpdfview.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M samples/pdfium_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 7 months ago (2015-05-08 19:01:59 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as bad79b3b02c9c56cf4eef436116bc9ad1bfb65b0 (presubmit successful).
5 years, 7 months ago (2015-05-08 19:02:09 UTC) #2
Lei Zhang
5 years, 7 months ago (2015-05-08 19:33:11 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698