Better error from pdfium_test when page too big to render.

Better error from pdfium_test when page too big to render.

BUG=pdfium:114
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/17ea732e8c8bba793aa57644f2325eeaaf4a1cbd

[Tom Sepez, 2015-05-08 17:32:16]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-05-08 17:32:16]

I'm not sure we can fix the underlying limitations on bitmap size without
opening a bunch of issues with int sizes, but we can give an error.

[Lei Zhang, 2015-05-08 18:05:16]

lgtm

https://codereview.chromium.org/1124423006/diff/20001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1124423006/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:15: #include
"../../third_party/base/nonstd_unique_ptr.h"
nit: alphabetical order.

https://codereview.chromium.org/1124423006/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:601: nonstd::unique_ptr<CFX_DIBitmap> pBitmap(new
CFX_DIBitmap);
nit: Can we get rid of tabs in this entire function?

[Tom Sepez, 2015-05-08 18:13:01]

https://codereview.chromium.org/1124423006/diff/20001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1124423006/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:15: #include
"../../third_party/base/nonstd_unique_ptr.h"
On 2015/05/08 18:05:15, Lei Zhang wrote:
> nit: alphabetical order.

Done.

https://codereview.chromium.org/1124423006/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:601: nonstd::unique_ptr<CFX_DIBitmap> pBitmap(new
CFX_DIBitmap);
On 2015/05/08 18:05:15, Lei Zhang wrote:
> nit: Can we get rid of tabs in this entire function?
Yes.  The only thing worse than tabs in files are people who think its okay to
have tabs in files (because you'll spend the rest of your life futily arguing
with them rather than doing work).

[Tom Sepez, 2015-05-08 18:53:59]

Committed patchset #3 (id:40001) manually as
17ea732e8c8bba793aa57644f2325eeaaf4a1cbd (presubmit successful).