Object.observe: Use [[DefineOwnProperty]] to create properties of changeRecord

Object.observe: Use [[DefineOwnProperty]] to create properties of changeRecord.

Note: The test here requires https://codereview.chromium.org/11364237/ to land in order to pass because Object.freeze calls Object.getOwnPropertyNames().

BUG=v8:2411
Committed: https://code.google.com/p/v8/source/detail?r=12983

[adamk, 2012-11-14 22:32:24]

https://codereview.chromium.org/11377171/diff/1/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/11377171/diff/1/src/object-observe.js#newcode32
src/object-observe.js:32: var InternalObjectDefineProperty =
$Object.defineProperty;
Not sure these are worth it, at least not until we actually segregate the
globals of these different builtins. Might as well just call
ObjectDefineProperty(), ObjectIsFrozen(), and ObjectFreeze() (all of which exist
and correspond to the proper methods on Object).

[rafaelw, 2012-11-14 22:40:56]

https://codereview.chromium.org/11377171/diff/1/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/11377171/diff/1/src/object-observe.js#newcode32
src/object-observe.js:32: var InternalObjectDefineProperty =
$Object.defineProperty;
Removed.

On 2012/11/14 22:32:24, adamk wrote:
> Not sure these are worth it, at least not until we actually segregate the
> globals of these different builtins. Might as well just call
> ObjectDefineProperty(), ObjectIsFrozen(), and ObjectFreeze() (all of which
exist
> and correspond to the proper methods on Object).

[rossberg, 2012-11-15 14:16:34]

LGTM, with nit.

https://codereview.chromium.org/11377171/diff/5001/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/11377171/diff/5001/src/object-observe.js#newc...
src/object-observe.js:165: ObjectDefineProperty(newRecord, prop, {
You should be able to use

%DefineOrRedefineDataProperty(newRecord, prop, changeRecord[prop], READ_ONLY +
DONT_DELETE)

which has less overhead.

[rafaelw, 2012-11-15 17:15:43]

https://codereview.chromium.org/11377171/diff/5001/src/object-observe.js
File src/object-observe.js (right):

https://codereview.chromium.org/11377171/diff/5001/src/object-observe.js#newc...
src/object-observe.js:165: ObjectDefineProperty(newRecord, prop, {
done.

On 2012/11/15 14:16:34, rossberg wrote:
> You should be able to use
> 
> %DefineOrRedefineDataProperty(newRecord, prop, changeRecord[prop], READ_ONLY +
> DONT_DELETE)
> 
> which has less overhead.