Chromium Code Reviews
Help | Chromium Project | Sign in
(446)

Issue 11364237: When using an Object as a set in Object.getOwnPropertyNames, null out the proto (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by adamk
Modified:
1 year, 5 months ago
Reviewers:
rossberg
CC:
v8-dev_googlegroups.com, rafaelw
Visibility:
Public.

Description

When using an Object as a set in Object.getOwnPropertyNames, null out the proto

Also apply the same fix elsewhere in v8natives.js

BUG=v8:2410
Committed: https://code.google.com/p/v8/source/detail?r=12982

Patch Set 1 #

Patch Set 2 : Added test case #

Patch Set 3 : Lint #

Total comments: 2

Patch Set 4 : Apply same fix elsewhere #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Lint Patch
M src/v8natives.js View 1 2 3 3 chunks +3 lines, -3 lines 1 comment ? errors Download
A + test/mjsunit/regress/regress-2410.js View 1 2 1 chunk +8 lines, -11 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 6
adamk
Let me know if there's another reviewer we should be sending random JS fixes to...(this ...
1 year, 5 months ago #1
rossberg
Nice catch! https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js#newcode1069 src/v8natives.js:1069: var attributesClone = {}; While you're at ...
1 year, 5 months ago #2
adamk
https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js File src/v8natives.js (right): https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js#newcode1069 src/v8natives.js:1069: var attributesClone = {}; On 2012/11/15 14:23:11, rossberg wrote: ...
1 year, 5 months ago #3
rossberg
On 2012/11/15 14:33:30, adamk wrote: > https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js > File src/v8natives.js (right): > > https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js#newcode1069 > ...
1 year, 5 months ago #4
adamk
Done.
1 year, 5 months ago #5
rossberg
1 year, 5 months ago #6
LGTM, will land.

https://codereview.chromium.org/11364237/diff/10001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/11364237/diff/10001/src/v8natives.js#newcode973
src/v8natives.js:973: var names = { __proto__: null };  // TODO(rossberg): use
sets once they are ready.
Actually, this case was correct. ;)  But cannot harm either.

I'll fix the line length.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6