Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1137683003: Only record one in n line endings to save space. (Closed)

Created:
5 years, 7 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
Reviewers:
Erik Corry, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only record one in n line endings to save space. R=yangguo@chromium.org BUG= Committed: https://crrev.com/b3d4bce593559276e68d3d7d9168f4351e4e5090 Cr-Commit-Position: refs/heads/master@{#28837}

Patch Set 1 #

Patch Set 2 : Try to make compilers happy #

Patch Set 3 : Merge up #

Patch Set 4 : Fix false detection of exotic newlines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -123 lines) Patch
M src/debug.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.cc View 1 2 1 chunk +2 lines, -11 lines 0 comments Download
M src/macros.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/messages.js View 1 2 9 chunks +95 lines, -36 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 3 chunks +159 lines, -25 lines 0 comments Download
M src/rewriter.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 2 chunks +81 lines, -44 lines 0 comments Download
M test/mjsunit/debug-sourceinfo.js View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Erik Corry Chromium.org
5 years, 7 months ago (2015-05-10 13:20:38 UTC) #1
Yang
I wonder whether it would make sense to move all the implementation to C++. Getting ...
5 years, 7 months ago (2015-05-11 06:39:41 UTC) #2
Erik Corry
Moving everything to C++ would be one option, but not something I am planning to ...
5 years, 7 months ago (2015-05-11 11:44:15 UTC) #4
Yang
lgtm. Though we should do a clean up at some point, moving all of the ...
5 years, 7 months ago (2015-05-19 14:10:28 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137683003/1
5 years, 7 months ago (2015-05-19 14:11:23 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/491)
5 years, 7 months ago (2015-05-19 14:18:02 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137683003/20001
5 years, 7 months ago (2015-05-20 09:34:40 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 10:01:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137683003/60001
5 years, 6 months ago (2015-06-08 11:26:28 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-08 12:00:52 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/b3d4bce593559276e68d3d7d9168f4351e4e5090 Cr-Commit-Position: refs/heads/master@{#28837}
5 years, 6 months ago (2015-06-08 12:01:10 UTC) #19
Erik Corry Chromium.org
5 years, 6 months ago (2015-06-08 14:24:03 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1155683010/ by erikcorry@chromium.org.

The reason for reverting is: Test failures
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/345....

Powered by Google App Engine
This is Rietveld 408576698