Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: src/rewriter.cc

Issue 1137683003: Only record one in n line endings to save space. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix false detection of exotic newlines Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/rewriter.cc
diff --git a/src/rewriter.cc b/src/rewriter.cc
index ee08d885f602f2d110e60a540cf7a0e4281ce241..bcfb814d44d8475e9d4b55f7012b59fba20f6a1b 100644
--- a/src/rewriter.cc
+++ b/src/rewriter.cc
@@ -235,6 +235,9 @@ bool Rewriter::Rewrite(ParseInfo* info) {
// eval('with ({x:1}) x = 1');
// the end position of the function generated for executing the eval code
// coincides with the end of the with scope which is the position of '1'.
+ // Note that this may mean the position is outside the source code
+ // completely if there is no terminal newline, curly brace, or semicolon,
+ // often the case for 'eval'.
int pos = function->end_position();
VariableProxy* result_proxy =
processor.factory()->NewVariableProxy(result, pos);
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698