Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1137643003: Revert of vea_unittest: Calculate per-frame encode latency (Closed)

Created:
5 years, 7 months ago by Justin Chuang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of vea_unittest: Calculate per-frame encode latency (patchset #15 id:280001 of https://codereview.chromium.org/1117853002/) Reason for revert: Fail to compile on x86 Chrome OS. Original issue's description: > vea_unittest: Calculate per-frame encode latency > > Calculates per-frame encode latency, which is basically the time delay from > input of each VideoFrame (VEA::Encode()) to output of the corresponding > BitstreamBuffer (VEA::Client::BitstreamBufferReady()). > > It calculates encode latency values at the 50th(median), 75th, and 95th percentiles. > > Also fix a wrong comment. > > BUG=345181 > TEST=Check "Encode latency for the 50%/75%/95%" in output logs. > > Committed: https://crrev.com/b21ffeee2aff4da8edb9808b2227165c37e5ce86 > Cr-Commit-Position: refs/heads/master@{#329819} TBR=owenlin@chromium.org,posciak@chromium.org,wuchengli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=345181 Committed: https://crrev.com/14c65a439e0c66b793a5cbea1273b30895d4e09f Cr-Commit-Position: refs/heads/master@{#329825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -133 lines) Patch
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 29 chunks +60 lines, -133 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Justin Chuang
Created Revert of vea_unittest: Calculate per-frame encode latency
5 years, 7 months ago (2015-05-14 10:19:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137643003/1
5 years, 7 months ago (2015-05-14 10:19:50 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-14 10:19:53 UTC) #4
Pawel Osciak
lgtm
5 years, 7 months ago (2015-05-14 10:28:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137643003/1
5 years, 7 months ago (2015-05-14 10:28:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 10:29:32 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 10:30:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14c65a439e0c66b793a5cbea1273b30895d4e09f
Cr-Commit-Position: refs/heads/master@{#329825}

Powered by Google App Engine
This is Rietveld 408576698