[rAc] [OSX] Set tooltip bubble arrow's anchor point based on the icon location.

chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm

Index: chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm
index e78b94f6a9bb4d428334fe14a6eeb1f37342021c..f163397ff8a0d88344ea481332a404ba26e19b50 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm
@@ -142,7 +142,8 @@
     //   (2) this way, the sizing computation can be cached.
     [checkbox_ sizeToFit];
 
-    tooltipController_.reset([[AutofillTooltipController alloc] init]);
+    tooltipController_.reset([[AutofillTooltipController alloc]
+                                 initWithArrowLocation:info_bubble::kTopRight]);

[groby-ooo-7-16, 2013/12/13 01:35:49]

That's a lot of code for a single kTopCenter... Why not

  [[tooltipController_ bubble] setArrowLocation:info_bubble::kTopCenter]; 

in this file and be done with it? 

[Ilya Sherman, 2013/12/13 02:17:07]

Well, because the tooltip controller doesn't always have a bubble showing, so at
a minimum we need to cache the bubble position in the AutofillTooltipController
class.  That basically leaves two remaining parts to the question: Can I just
leave the autofill_bubble_controller.* files alone, and can I leave
autofill_main_container.mm alone by not changing the init method.

To the first point: I could leave it alone, but the current structure seems more
explicit to me, which I think is a positive.  Still, I could remove that part if
you'd really like.

To the second: I could move the setter out of the -init: method, but then new
users of the bubble -- such as my CL to add a (?) icon to the phone number field
-- might forget to set the correct arrow location.  I could revert this part of
the change too, but I would push back a little harder ;)

     [tooltipController_ setImage:
         ui::ResourceBundle::GetSharedInstance().GetNativeImageNamed(
             IDR_AUTOFILL_TOOLTIP_ICON).ToNSImage()];