[rAc] [OSX] Set tooltip bubble arrow's anchor point based on the icon location.

chrome/browser/ui/cocoa/autofill/autofill_notification_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_notification_controller.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
@@ skipping 124 matching lines @@
     [checkbox_ setState:(notification->checked() ? NSOnState : NSOffState)];
     [checkbox_ setAttributedTitle:[textview_ textStorage]];
     [checkbox_ setTarget:self];
     [checkbox_ setAction:@selector(checkboxClicked:)];
     // Set the size that preferredSizeForWidth will use. Do this here because
     //   (1) preferredSizeForWidth is logically const, and so shouldn't have a
     //       side-effect of updating the checkbox's frame, and
     //   (2) this way, the sizing computation can be cached.
     [checkbox_ sizeToFit];
 
-    tooltipController_.reset([[AutofillTooltipController alloc] init]);
+    tooltipController_.reset([[AutofillTooltipController alloc]
+                                 initWithArrowLocation:info_bubble::kTopRight]);

[groby-ooo-7-16, 2013/12/13 01:35:49]

That's a lot of code for a single kTopCenter... Why not

  [[tooltipController_ bubble] setArrowLocation:info_bubble::kTopCenter]; 

in this file and be done with it? 

[Ilya Sherman, 2013/12/13 02:17:07]

Well, because the tooltip controller doesn't always have a bubble showing, so at
a minimum we need to cache the bubble position in the AutofillTooltipController
class.  That basically leaves two remaining parts to the question: Can I just
leave the autofill_bubble_controller.* files alone, and can I leave
autofill_main_container.mm alone by not changing the init method.

To the first point: I could leave it alone, but the current structure seems more
explicit to me, which I think is a positive.  Still, I could remove that part if
you'd really like.

To the second: I could move the setter out of the -init: method, but then new
users of the bubble -- such as my CL to add a (?) icon to the phone number field
-- might forget to set the correct arrow location.  I could revert this part of
the change too, but I would push back a little harder ;)

     [tooltipController_ setImage:
         ui::ResourceBundle::GetSharedInstance().GetNativeImageNamed(
             IDR_AUTOFILL_TOOLTIP_ICON).ToNSImage()];
     [tooltipController_ setMessage:
         base::SysUTF16ToNSString(notification->tooltip_text())];
     [[tooltipController_ view] setHidden:
         [[tooltipController_ message] length] == 0];
 
     [view setSubviews:@[ textview_, checkbox_, [tooltipController_ view] ]];
   }
@@ skipping 107 matching lines @@
 }
 
 - (BOOL)textView:(NSTextView *)textView
    clickedOnLink:(id)link
          atIndex:(NSUInteger)charIndex {
   delegate_->LinkClicked(linkURL_);
   return YES;
 }
 
 @end