Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137543005: Type check binary expressions (Closed)

Created:
5 years, 7 months ago by vsm
Modified:
5 years, 7 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase and remove assert #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -46 lines) Patch
M lib/runtime/dart/_interceptors.js View 1 1 chunk +2 lines, -2 lines 2 comments Download
M lib/runtime/dart/_js_helper.js View 1 9 chunks +13 lines, -13 lines 0 comments Download
M lib/runtime/dart/core.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/checker/checker.dart View 1 1 chunk +46 lines, -3 lines 0 comments Download
M lib/src/dart_sdk.dart View 1 chunk +5 lines, -1 line 0 comments Download
M test/checker/checker_test.dart View 9 chunks +32 lines, -18 lines 0 comments Download
M test/checker/inferred_type_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M test/codegen/expect/fieldtest.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/fieldtest.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/core/exceptions.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vsm
5 years, 7 months ago (2015-05-20 00:03:02 UTC) #2
Leaf
lgtm https://codereview.chromium.org/1137543005/diff/20001/lib/runtime/dart/_interceptors.js File lib/runtime/dart/_interceptors.js (right): https://codereview.chromium.org/1137543005/diff/20001/lib/runtime/dart/_interceptors.js#newcode450 lib/runtime/dart/_interceptors.js:450: i = 252645135 & dart.notNull(dart.notNull(i) + dart.notNull(dart.as(JSInt._shru(i, 4), ...
5 years, 7 months ago (2015-05-20 16:13:22 UTC) #3
vsm
Committed patchset #2 (id:20001) manually as 9960e5066a59d617a936dde516acaae950ed0be5 (presubmit successful).
5 years, 7 months ago (2015-05-20 16:24:28 UTC) #4
vsm
5 years, 7 months ago (2015-05-20 16:39:10 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1137543005/diff/20001/lib/runtime/dart/_inter...
File lib/runtime/dart/_interceptors.js (right):

https://codereview.chromium.org/1137543005/diff/20001/lib/runtime/dart/_inter...
lib/runtime/dart/_interceptors.js:450: i = 252645135 &
dart.notNull(dart.notNull(i) + dart.notNull(dart.as(JSInt._shru(i, 4),
core.num)));
On 2015/05/20 16:13:22, leafp wrote:
> Ugly.  Do we really not know the type of _shru?  

It's declared dynamic for some reason.  Addressing in another CL.

Powered by Google App Engine
This is Rietveld 408576698