Type check binary expressions

test/checker/checker_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// General type checking tests
 library dev_compiler.test.checker_test;
 
 import 'package:unittest/unittest.dart';
 
 import 'package:dev_compiler/src/testing.dart';
@@ skipping 90 matching lines @@
       '/helper.dart': '''
       dynamic toString = (int x) => x + 42;
       dynamic hashCode = "hello";
       ''',
       '/main.dart': '''
       import 'helper.dart' as helper;
 
       class A {
         String x = "hello world";
 
-        void baz1(y) => x + y;
-        static baz2(y) => y + y;
+        void baz1(y) => x + /*info:DynamicCast*/y;
+        static baz2(y) => /*info:DynamicInvoke*/y + y;
       }
 
       void foo(String str) {
         print(str);
       }
 
       class B {
         String toString([int arg]) => arg.toString();
       }
 
@@ skipping 849 matching lines @@
       }
       int i2i(int x) => x;
       num n2n(num x) => x;
       void main() {
          {
            I2I f;
            f = new A();
            f = /*severe:StaticTypeError*/new B();
            f = i2i;
            f = /*warning:DownCastComposite*/n2n;
-           f = /*warning:DownCastComposite*/(i2i as Object);
-           f = /*warning:DownCastComposite*/(n2n as Function);
+           f = /*warning:DownCastComposite*/i2i as Object;
+           f = /*warning:DownCastComposite*/n2n as Function;
          }
          {
            N2N f;
            f = /*severe:StaticTypeError*/new A();
            f = new B();
            f = /*warning:DownCastComposite*/i2i;
            f = n2n;
-           f = /*warning:DownCastComposite*/(i2i as Object);
-           f = /*warning:DownCastComposite*/(n2n as Function);
+           f = /*warning:DownCastComposite*/i2i as Object;
+           f = /*warning:DownCastComposite*/n2n as Function;
          }
          {
            A f;
            f = new A();
            f = /*severe:StaticTypeError*/new B();
            f = /*severe:StaticTypeError*/i2i;
            f = /*severe:StaticTypeError*/n2n;
-           f = /*warning:DownCastImplicit*/(i2i as Object);
-           f = /*warning:DownCastImplicit*/(n2n as Function);
+           f = /*warning:DownCastImplicit*/i2i as Object;
+           f = /*warning:DownCastImplicit*/n2n as Function;
          }
          {
            B f;
            f = /*severe:StaticTypeError*/new A();
            f = new B();
            f = /*severe:StaticTypeError*/i2i;
            f = /*severe:StaticTypeError*/n2n;
-           f = /*warning:DownCastImplicit*/(i2i as Object);
-           f = /*warning:DownCastImplicit*/(n2n as Function);
+           f = /*warning:DownCastImplicit*/i2i as Object;
+           f = /*warning:DownCastImplicit*/n2n as Function;
          }
          {
            Function f;
            f = new A();
            f = new B();
            f = i2i;
            f = n2n;
-           f = /*warning:DownCastImplicit*/(i2i as Object);
+           f = /*warning:DownCastImplicit*/i2i as Object;
            f = (n2n as Function);
          }
       }
    '''
     });
   });
 
   test('Function typing and subtyping: void', () {
     testChecker({
       '/main.dart': '''
 
       class A {
         void bar() => null;
         void foo() => bar; // allowed
       }
    '''
     });
   });
 
   test('Closure wrapping of literals', () {
     testChecker({
       '/main.dart': '''
       typedef T F<T>(T t1, T t2);
       typedef dynamic D(t1, t2);
 
       void main() {
-        F f1 = (x, y) => x + y;
-        F<int> f2 = /*warning:ClosureWrapLiteral*/(x, y) => x + y;
-        D f3 = (x, y) => x + y;
-        Function f4 = (x, y) => x + y;
+        F f1 = (x, y) => /*info:DynamicInvoke*/x + y;
+        F<int> f2 = /*warning:ClosureWrapLiteral*/(x, y) => /*info:DynamicInvoke*/x + y;
+        D f3 = (x, y) => /*info:DynamicInvoke*/x + y;
+        Function f4 = (x, y) => /*info:DynamicInvoke*/x + y;
         f2 = /*warning:ClosureWrap*/f1;
         f1 = (int x, int y) => x + y;
         f2 = /*severe:StaticTypeError*/(int x) => -x;
       }
    '''
     }, wrapClosures: true, inferDownwards: false);
   });
 
   test('Generic subtyping: invariance', () {
     testChecker({
@@ skipping 889 matching lines @@
             A operator -(B b) {}
           }
 
           foo() => new A();
 
           test() {
             A a = new A();
             B b = new B();
             var c = foo();
             a = a * b;
-            a = a * /*pass should be warning:DownCastImplicit*/c;
+            a = a * /*info:DynamicCast*/c;
             a = a / b;
             a = a ~/ b;
             a = a % b;
             a = a + b;
-            a = a + /*pass should be severe:StaticTypeError*/a;
+            a = a + /*severe:StaticTypeError*/a;
             a = a - b;
             b = /*severe:StaticTypeError*/b - b;
             a = a << b;
             a = a >> b;
             a = a & b;
             a = a ^ b;
             a = a | b;
-            c = (/*pass should be info:DynamicInvoke*/c + b);
+            c = (/*info:DynamicInvoke*/c + b);
+
+            String x = 'hello';
+            int y = 42;
+            x = x + x;
+            x = x + /*info:DynamicCast*/c;
+            x = x + /*severe:StaticTypeError*/y;
+
+            bool p = true;
+            p = p && p;
+            p = p && /*info:DynamicCast*/c;
+            p = (/*info:DynamicCast*/c) && p;
+            p = (/*info:DynamicCast*/c) && /*info:DynamicCast*/c;
+            p = (/*severe:StaticTypeError*/y) && p;
+            p = c == y;
           }
        '''
     });
   });
 
   test('compound assignments', () {
     testChecker({
       '/main.dart': '''
           class A {
             A operator *(B b) {}
@@ skipping 933 matching lines @@
             f = bar as II2D;
             f = bar as DD2I;
             f = bar as DI2D;
             f = bar as ID2D;
             f = bar as DD2D;
           }
       '''
     });
   });
 }