[Extensions] Polish the suspicious extension bubble

[Extensions] Polish the suspicious extension bubble

Adjust the string for single extensions ("the following extension" instead of
"some extensions"), and point the link to the proper place.

BUG=474091
TBR=avi@chromium.org (micro cocoa change)

Committed: https://crrev.com/9cb8498a6318eb3aef01d6f4aafa8be15ea60347
Cr-Commit-Position: refs/heads/master@{#330113}

[Devlin, 2015-05-15 15:46:33]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Finnur, 2015-05-15 15:58:47]

LGTM, couple of nits.

https://codereview.chromium.org/1137503006/diff/1/chrome/app/chromium_strings...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/1137503006/diff/1/chrome/app/chromium_strings...
chrome/app/chromium_strings.grd:792: </message>
You should probably use jshin's new system?
https://codereview.chromium.org/1103293004/

I'm OK with a follow-up patch for that (especially if you plan to merge, I'm not
sure his patch is in the branch).

https://codereview.chromium.org/1137503006/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_message_bubble_controller.h (right):

https://codereview.chromium.org/1137503006/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_message_bubble_controller.h:53: bool
for_single_extension) const = 0;
nit: I would have made this take an int extension_count, because i18n is
potentially a lot trickier than just differences in singular vs plural (even
though the problem you are trying to solve is just that).

[Devlin, 2015-05-15 16:12:42]

https://codereview.chromium.org/1137503006/diff/1/chrome/app/chromium_strings...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/1137503006/diff/1/chrome/app/chromium_strings...
chrome/app/chromium_strings.grd:792: </message>
On 2015/05/15 15:58:47, Finnur wrote:
> You should probably use jshin's new system?
> https://codereview.chromium.org/1103293004/
> 
> I'm OK with a follow-up patch for that (especially if you plan to merge, I'm
not
> sure his patch is in the branch).

Oh, nifty - never seen that new system before.  I'll do that in a follow-up next
week. :)  Thanks for pointing it out!

https://codereview.chromium.org/1137503006/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_message_bubble_controller.h (right):

https://codereview.chromium.org/1137503006/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_message_bubble_controller.h:53: bool
for_single_extension) const = 0;
On 2015/05/15 15:58:47, Finnur wrote:
> nit: I would have made this take an int extension_count, because i18n is
> potentially a lot trickier than just differences in singular vs plural (even
> though the problem you are trying to solve is just that).

Yeah, that's probably better.  Done.

[Devlin, 2015-05-15 16:12:52]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-05-15 16:12:52]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1137503006/#ps20001
(title: "Finnur's")

[commit-bot: I haz the power, 2015-05-15 16:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137503006/20001

[Devlin, 2015-05-15 16:20:32]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2015-05-15 16:22:47]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-05-15 16:23:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137503006/20001

[commit-bot: I haz the power, 2015-05-15 16:58:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-15 16:59:34]

Patchset 2 (id:??) landed as
https://crrev.com/9cb8498a6318eb3aef01d6f4aafa8be15ea60347
Cr-Commit-Position: refs/heads/master@{#330113}