chrome/browser/extensions/proxy_overridden_bubble_controller.cc - Issue 1137503006: [Extensions] Polish the suspicious extension bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/proxy_overridden_bubble_controller.cc

Issue 1137503006: [Extensions] Polish the suspicious extension bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finnur's Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/ntp_overridden_bubble_controller.cc ('k') | chrome/browser/extensions/settings_api_bubble_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/proxy_overridden_bubble_controller.cc

diff --git a/chrome/browser/extensions/proxy_overridden_bubble_controller.cc b/chrome/browser/extensions/proxy_overridden_bubble_controller.cc

index 3d81d16b86449be79663ae6e9f610d0221f3207a..0a401413c0cf95d08d1906360f00c6ec532b5e10 100644

--- a/chrome/browser/extensions/proxy_overridden_bubble_controller.cc

+++ b/chrome/browser/extensions/proxy_overridden_bubble_controller.cc

@@ -44,7 +44,8 @@ class ProxyOverriddenBubbleDelegate

ExtensionMessageBubbleController::BubbleAction user_action) override;

void PerformAction(const ExtensionIdList& list) override;

base::string16 GetTitle() const override;

- base::string16 GetMessageBody(bool anchored_to_browser_action) const override;

+ base::string16 GetMessageBody(bool anchored_to_browser_action,

+ int extension_count) const override;

base::string16 GetOverflowText(

const base::string16& overflow_count) const override;

GURL GetLearnMoreUrl() const override;

@@ -122,7 +123,8 @@ base::string16 ProxyOverriddenBubbleDelegate::GetTitle() const {

}

base::string16 ProxyOverriddenBubbleDelegate::GetMessageBody(

- bool anchored_to_browser_action) const {

+ bool anchored_to_browser_action,

+ int extension_count) const {

if (anchored_to_browser_action) {

return l10n_util::GetStringUTF16(

IDS_EXTENSIONS_PROXY_CONTROLLED_FIRST_LINE_EXTENSION_SPECIFIC);