components/gcm_driver/gcm_stats_recorder_impl_unittest.cc - Issue 1137463003: Support getting and deleting token for Instance ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

Issue 1137463003: Support getting and deleting token for Instance ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch to land Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/gcm_stats_recorder_impl.cc ('k') | components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

diff --git a/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc b/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

index 1223f6724f1ac8a1b5c1f6ba73b0f1cec718c114..e45ab59f2e4fb5797c5c56b4ef5bdc02fb6c51a6 100644

--- a/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

+++ b/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

@@ -338,7 +338,7 @@ class GCMStatsRecorderImplTest : public testing::Test {

EXPECT_EQ(details, queue.front().details) << remark;

}

- std::vector<std::string> sender_ids_;

+ std::string sender_ids_;

GCMStatsRecorderImpl recorder_;

};

@@ -348,8 +348,7 @@ GCMStatsRecorderImplTest::GCMStatsRecorderImplTest(){

GCMStatsRecorderImplTest::~GCMStatsRecorderImplTest() {}

void GCMStatsRecorderImplTest::SetUp(){

- sender_ids_.push_back("s1");

- sender_ids_.push_back("s2");

+ sender_ids_ = "s1,s2";

recorder_.SetRecording(true);

}