Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl.cc

Issue 1137463003: Support getting and deleting token for Instance ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch to land Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_stats_recorder_impl.cc
diff --git a/components/gcm_driver/gcm_stats_recorder_impl.cc b/components/gcm_driver/gcm_stats_recorder_impl.cc
index 524372d67ecf7dcbf0b2c40f823e66b7e712a104..6bf6963fcc8308d4812e89cc3650b1b4ae35e626 100644
--- a/components/gcm_driver/gcm_stats_recorder_impl.cc
+++ b/components/gcm_driver/gcm_stats_recorder_impl.cc
@@ -272,14 +272,14 @@ void GCMStatsRecorderImpl::RecordConnectionResetSignaled(
void GCMStatsRecorderImpl::RecordRegistration(
const std::string& app_id,
- const std::string& sender_ids,
+ const std::string& senders,
const std::string& event,
const std::string& details) {
RegistrationActivity data;
RegistrationActivity* inserted_data = InsertCircularBuffer(
&registration_activities_, data);
inserted_data->app_id = app_id;
- inserted_data->sender_ids = sender_ids;
+ inserted_data->sender_ids = senders;
inserted_data->event = event;
inserted_data->details = details;
NotifyActivityRecorded();
@@ -297,22 +297,22 @@ void GCMStatsRecorderImpl::RecordRegistrationSent(
void GCMStatsRecorderImpl::RecordRegistrationResponse(
const std::string& app_id,
- const std::vector<std::string>& sender_ids,
+ const std::string& senders,
RegistrationRequest::Status status) {
if (!is_recording_)
return;
- RecordRegistration(app_id, JoinString(sender_ids, ","),
+ RecordRegistration(app_id, senders,
"Registration response received",
GetRegistrationStatusString(status));
}
void GCMStatsRecorderImpl::RecordRegistrationRetryRequested(
const std::string& app_id,
- const std::vector<std::string>& sender_ids,
+ const std::string& senders,
int retries_left) {
if (!is_recording_)
return;
- RecordRegistration(app_id, JoinString(sender_ids, ","),
+ RecordRegistration(app_id, senders,
"Registration retry requested",
base::StringPrintf("Retries left: %d", retries_left));
}
« no previous file with comments | « components/gcm_driver/gcm_stats_recorder_impl.h ('k') | components/gcm_driver/gcm_stats_recorder_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698