Add upstream bits necessary for iOS card unmask prompt.

Add upstream bits necessary for iOS card unmask prompt.

See https://chromereviews.googleplex.com/193957013/ for the associated downstream changes.

BUG=484806
Committed: https://crrev.com/09d373f7f6839d3b3f471c76ae5a91d234ce3b9b
Cr-Commit-Position: refs/heads/master@{#330529}

[Justin Donnelly, 2015-05-14 17:19:03]

jdonnelly@chromium.org changed reviewers:
+ dconnelly@chromium.org, estade@chromium.org

[Evan Stade, 2015-05-14 22:41:38]

autofill/core/browser lgtm

https://codereview.chromium.org/1137403002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/1137403002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:1305:
FormFieldData selected_field;
why not just makes this form.fields[2] for all platforms

[Justin Donnelly, 2015-05-14 22:43:45]

https://codereview.chromium.org/1137403002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/1137403002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:1305:
FormFieldData selected_field;
On 2015/05/14 22:41:38, Evan Stade wrote:
> why not just makes this form.fields[2] for all platforms

I figured it would be better to continue to test the common case on the other
platforms, where the first form field is selected and that fills out the whole
form. But I don't feel strongly about it if you prefer it the other way.

[Evan Stade, 2015-05-14 22:45:34]

https://codereview.chromium.org/1137403002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/1137403002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:1305:
FormFieldData selected_field;
On 2015/05/14 22:43:45, Justin Donnelly wrote:
> On 2015/05/14 22:41:38, Evan Stade wrote:
> > why not just makes this form.fields[2] for all platforms
> 
> I figured it would be better to continue to test the common case on the other
> platforms, where the first form field is selected and that fills out the whole
> form. But I don't feel strongly about it if you prefer it the other way.

that's not really what this test is testing. The other test you updated tests
that.

[Justin Donnelly, 2015-05-14 22:45:43]

dconnelly - please take a look at components/autofill/ios/.

[Justin Donnelly, 2015-05-15 19:26:58]

https://codereview.chromium.org/1137403002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/1137403002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:1305:
FormFieldData selected_field;
On 2015/05/14 22:45:34, Evan Stade wrote:
> On 2015/05/14 22:43:45, Justin Donnelly wrote:
> > On 2015/05/14 22:41:38, Evan Stade wrote:
> > > why not just makes this form.fields[2] for all platforms
> > 
> > I figured it would be better to continue to test the common case on the
other
> > platforms, where the first form field is selected and that fills out the
whole
> > form. But I don't feel strongly about it if you prefer it the other way.
> 
> that's not really what this test is testing. The other test you updated tests
> that.

Understood that we're testing the logging here. I guess part of my motivation
was to avoid using the magic index 2. We're using it on iOS anyway, but this way
it's documented clearly why. But I could see this setup making it seem like we
care which field is selected on non-iOS which is misleading.

Like I said, no big deal. Removed.

[Justin Donnelly, 2015-05-19 14:27:25]

Patchset #6 (id:90001) has been deleted

[dconnelly, 2015-05-19 14:49:56]

lgtm

[Justin Donnelly, 2015-05-19 14:50:28]

The CQ bit was checked by jdonnelly@chromium.org

[Justin Donnelly, 2015-05-19 14:50:29]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1137403002/#ps110001
(title: "Add clearActiveElement to autofill_controller.js")

[commit-bot: I haz the power, 2015-05-19 14:51:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137403002/110001

[commit-bot: I haz the power, 2015-05-19 17:04:18]

Committed patchset #6 (id:110001)

[commit-bot: I haz the power, 2015-05-19 17:05:43]

Patchset 6 (id:??) landed as
https://crrev.com/09d373f7f6839d3b3f471c76ae5a91d234ce3b9b
Cr-Commit-Position: refs/heads/master@{#330529}

[Dan Beam, 2015-05-20 23:31:51]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-05-20 23:31:52]

https://codereview.chromium.org/1137403002/diff/110001/components/autofill/io...
File components/autofill/ios/browser/resources/autofill_controller.js (right):

https://codereview.chromium.org/1137403002/diff/110001/components/autofill/io...
components/autofill/ios/browser/resources/autofill_controller.js:138:
__gCrWeb.autofill['storeActiveElement'] = function() {
why are you missing ['braces'] and .dot notation?  they do the same thing... but
.dotNotation is mildly better when .propName is a legal identifier.

are you worried about property renaming or something?

[Dan Beam, 2015-05-20 23:32:06]

https://codereview.chromium.org/1137403002/diff/110001/components/autofill/io...
File components/autofill/ios/browser/resources/autofill_controller.js (right):

https://codereview.chromium.org/1137403002/diff/110001/components/autofill/io...
components/autofill/ios/browser/resources/autofill_controller.js:138:
__gCrWeb.autofill['storeActiveElement'] = function() {
On 2015/05/20 23:31:52, Dan Beam wrote:
> why are you missing ['braces'] and .dot notation?  they do the same thing...
but
> .dotNotation is mildly better when .propName is a legal identifier.
> 
> are you worried about property renaming or something?

s/missing/mixing

[Justin Donnelly, 2015-05-21 00:36:01]

https://codereview.chromium.org/1137403002/diff/110001/components/autofill/io...
File components/autofill/ios/browser/resources/autofill_controller.js (right):

https://codereview.chromium.org/1137403002/diff/110001/components/autofill/io...
components/autofill/ios/browser/resources/autofill_controller.js:138:
__gCrWeb.autofill['storeActiveElement'] = function() {
On 2015/05/20 23:31:52, Dan Beam wrote:
> why are you missing ['braces'] and .dot notation?  they do the same thing...
but
> .dotNotation is mildly better when .propName is a legal identifier.
> 
> are you worried about property renaming or something?

I don't know, I'm pretty new to working with this code.

dconnelly, do you know the motivation for brace notation in the injected
javascript?

[dconnelly, 2015-05-21 07:27:54]

https://codereview.chromium.org/1137403002/diff/110001/components/autofill/io...
File components/autofill/ios/browser/resources/autofill_controller.js (right):

https://codereview.chromium.org/1137403002/diff/110001/components/autofill/io...
components/autofill/ios/browser/resources/autofill_controller.js:138:
__gCrWeb.autofill['storeActiveElement'] = function() {
On 2015/05/21 00:36:01, Justin Donnelly wrote:
> On 2015/05/20 23:31:52, Dan Beam wrote:
> > why are you missing ['braces'] and .dot notation?  they do the same thing...
> but
> > .dotNotation is mildly better when .propName is a legal identifier.
> > 
> > are you worried about property renaming or something?
> 
> I don't know, I'm pretty new to working with this code.
> 
> dconnelly, do you know the motivation for brace notation in the injected
> javascript?

Yeah, it's some Closure compiler thing. The functions called from outside need
to be in the brace notation or they'll get squashed. You can look at some of the
other ios_internal JS code to see more.