components/autofill/core/browser/autofill_metrics_unittest.cc - Issue 1137403002: Add upstream bits necessary for iOS card unmask prompt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 1137403002: Add upstream bits necessary for iOS card unmask prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add clearActiveElement to autofill_controller.js Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/ios/browser/js_autofill_manager.h » ('j') | components/autofill/ios/browser/resources/autofill_controller.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics_unittest.cc

diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc

index 3764d3fe4b9bd3f20c26c96a7cb12a1612925b12..b867153fe84d692aeb4d557eaa15802946aadc5e 100644

--- a/components/autofill/core/browser/autofill_metrics_unittest.cc

+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc

@@ -1310,7 +1310,7 @@ TEST_F(AutofillMetricsTest, CreditCardSelectedFormEvents) {

"10000000-0000-0000-0000-000000000002", 0); // masked server card

autofill_manager_->FillOrPreviewForm(

AutofillDriver::FORM_DATA_ACTION_FILL,

- 0, form, form.fields.front(),

+ 0, form, form.fields[2],

autofill_manager_->MakeFrontendID(guid, SuggestionBackendID()));

histogram_tester.ExpectBucketCount(

"Autofill.FormEvents.CreditCard",

@@ -1332,11 +1332,11 @@ TEST_F(AutofillMetricsTest, CreditCardSelectedFormEvents) {

"10000000-0000-0000-0000-000000000002", 0); // masked server card

autofill_manager_->FillOrPreviewForm(

AutofillDriver::FORM_DATA_ACTION_FILL,

- 0, form, form.fields.front(),

+ 0, form, form.fields[2],

autofill_manager_->MakeFrontendID(guid, SuggestionBackendID()));

autofill_manager_->FillOrPreviewForm(

AutofillDriver::FORM_DATA_ACTION_FILL,

- 0, form, form.fields.front(),

+ 0, form, form.fields[2],

autofill_manager_->MakeFrontendID(guid, SuggestionBackendID()));

histogram_tester.ExpectBucketCount(

"Autofill.FormEvents.CreditCard",