Show the eject button only for removabled and file handlers.

Show the eject button only for removables and file handlers.

This CL passes the "configure" and "source" flag to VolumeManager. Additionally
all other volume types have those flags, so we can add a link to disable Drive
as it's configuration. Finally, logic for displaying the "eject" icon has been
simplified.

TBR=fukino@chromium.org
TEST=browser_test: *FileManagerPrivateApi*Mount*
BUG=447101
Committed: https://crrev.com/b9c370ab86c7f896a17853b1d502635efc834fbb
Cr-Commit-Position: refs/heads/master@{#330080}

[mtomasz, 2015-05-14 10:03:07]

mtomasz@chromium.org changed reviewers:
+ hirono@chromium.org

[mtomasz, 2015-05-14 10:06:47]

@hirono: PTAL. Thanks!

[hirono, 2015-05-14 10:43:09]

https://codereview.chromium.org/1137383002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/volume_manager.cc (right):

https://codereview.chromium.org/1137383002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/volume_manager.cc:140: configurable_(false)
{
Please also initialize source_.

https://codereview.chromium.org/1137383002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/service.cc (right):

https://codereview.chromium.org/1137383002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/service.cc:342: }
Please fix the indent.

https://codereview.chromium.org/1137383002/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/file_manager_private.idl (right):

https://codereview.chromium.org/1137383002/diff/40001/chrome/common/extension...
chrome/common/extensions/api/file_manager_private.idl:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
Please update third_party/closure_compiler/externs/file_manager_private.js.

https://codereview.chromium.org/1137383002/diff/40001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/file_browser/mount_test/test.js
(right):

https://codereview.chromium.org/1137383002/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/file_browser/mount_test/test.js:97:
profile: {profileId: "", displayName: "", isCurrentProfile: true}
"" -> ''?

https://codereview.chromium.org/1137383002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/volume_manager.js (right):

https://codereview.chromium.org/1137383002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/volume_manager.js:178: * @return
{string} Source of the volume's data.
Please use enum name if possible.

https://codereview.chromium.org/1137383002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/volume_manager.js:268:
console.log(JSON.stringify(volumeMetadata));
nit: Please remove debug log.

[mtomasz, 2015-05-15 02:03:38]

https://codereview.chromium.org/1137383002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/volume_manager.cc (right):

https://codereview.chromium.org/1137383002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/volume_manager.cc:140: configurable_(false)
{
On 2015/05/14 10:43:08, hirono wrote:
> Please also initialize source_.

Oops. Done.

https://codereview.chromium.org/1137383002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/service.cc (right):

https://codereview.chromium.org/1137383002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/service.cc:342: }
On 2015/05/14 10:43:09, hirono wrote:
> Please fix the indent.

Done.

https://codereview.chromium.org/1137383002/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/file_manager_private.idl (right):

https://codereview.chromium.org/1137383002/diff/40001/chrome/common/extension...
chrome/common/extensions/api/file_manager_private.idl:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
On 2015/05/14 10:43:09, hirono wrote:
> Please update third_party/closure_compiler/externs/file_manager_private.js.
> 

Done.

https://codereview.chromium.org/1137383002/diff/40001/chrome/test/data/extens...
File chrome/test/data/extensions/api_test/file_browser/mount_test/test.js
(right):

https://codereview.chromium.org/1137383002/diff/40001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/file_browser/mount_test/test.js:97:
profile: {profileId: "", displayName: "", isCurrentProfile: true}
On 2015/05/14 10:43:09, hirono wrote:
> "" -> ''?

Done.

https://codereview.chromium.org/1137383002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/volume_manager.js (right):

https://codereview.chromium.org/1137383002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/volume_manager.js:178: * @return
{string} Source of the volume's data.
On 2015/05/14 10:43:09, hirono wrote:
> Please use enum name if possible.

Done.

https://codereview.chromium.org/1137383002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/volume_manager.js:268:
console.log(JSON.stringify(volumeMetadata));
On 2015/05/14 10:43:09, hirono wrote:
> nit: Please remove debug log.

Done.

[mtomasz, 2015-05-15 03:57:25]

The CQ bit was checked by mtomasz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-15 03:57:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137383002/60001

[commit-bot: I haz the power, 2015-05-15 04:51:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 04:51:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hirono, 2015-05-15 08:27:46]

lgtm!

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/volume_manager.h (right):

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/volume_manager.h:103: const Source source()
const { return source_; }
nit for return type: const Source -> Source ?

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/volume_manager.h:243: void
AddVolumeForTesting(linked_ptr<Volume> volume);
nit: const linked_ptr<Volume>& volume ?

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/service.h (right):

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/service.h:137: // If the extension
is not a provider, or it doesn't exist, then NULL is
nit: NULL is returned -> false is returned.

https://codereview.chromium.org/1137383002/diff/60001/chrome/common/extension...
File chrome/common/extensions/api/file_manager_private.idl (right):

https://codereview.chromium.org/1137383002/diff/60001/chrome/common/extension...
chrome/common/extensions/api/file_manager_private.idl:535: 
nit: Please remove the space if the line contains it.

https://codereview.chromium.org/1137383002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/1137383002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:484:
VolumeItem.prototype.setContextMenu = function(menu) {
Can we make it private?

[mtomasz, 2015-05-15 09:32:37]

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/volume_manager.h (right):

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/volume_manager.h:103: const Source source()
const { return source_; }
On 2015/05/15 08:27:45, hirono wrote:
> nit for return type: const Source -> Source ?

Done.

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/volume_manager.h:243: void
AddVolumeForTesting(linked_ptr<Volume> volume);
On 2015/05/15 08:27:45, hirono wrote:
> nit: const linked_ptr<Volume>& volume ?

I was considering it, but it seemed that linked_ptr via value is more often used
(2x more). I guess it's because they are very small (2 pointers) of data.
However, it seems reasonable to use a reference instead. Done.

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/service.h (right):

https://codereview.chromium.org/1137383002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/service.h:137: // If the extension
is not a provider, or it doesn't exist, then NULL is
On 2015/05/15 08:27:45, hirono wrote:
> nit: NULL is returned -> false is returned.

Done.

https://codereview.chromium.org/1137383002/diff/60001/chrome/common/extension...
File chrome/common/extensions/api/file_manager_private.idl (right):

https://codereview.chromium.org/1137383002/diff/60001/chrome/common/extension...
chrome/common/extensions/api/file_manager_private.idl:535: 
On 2015/05/15 08:27:45, hirono wrote:
> nit: Please remove the space if the line contains it.

Done.

https://codereview.chromium.org/1137383002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/1137383002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:484:
VolumeItem.prototype.setContextMenu = function(menu) {
On 2015/05/15 08:27:45, hirono wrote:
> Can we make it private?

Good idea. Done.

[mtomasz, 2015-05-15 09:32:48]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-05-15 09:32:49]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org
Link to the patchset: https://codereview.chromium.org/1137383002/#ps80001
(title: "Fixed tests.")

[commit-bot: I haz the power, 2015-05-15 09:32:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137383002/80001

[mtomasz, 2015-05-15 09:36:48]

mtomasz@chromium.org changed reviewers:
+ fukino@chromium.org

[mtomasz, 2015-05-15 09:36:58]

@fukino: PTAL at externs. Thanks!

[commit-bot: I haz the power, 2015-05-15 09:39:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 09:39:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mtomasz, 2015-05-15 09:59:46]

@fukino: Let me TBR. The change is trivial, the CL is already reviewed by
@hirono and I'd really like to get this CL committed before the branch cut.

[mtomasz, 2015-05-15 09:59:51]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-05-15 10:00:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137383002/80001

[fukino, 2015-05-15 10:24:41]

On 2015/05/15 09:36:58, mtomasz wrote:
> @fukino: PTAL at externs. Thanks!

externs lgtm!

[commit-bot: I haz the power, 2015-05-15 11:54:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-15 11:55:06]

Patchset 5 (id:??) landed as
https://crrev.com/b9c370ab86c7f896a17853b1d502635efc834fbb
Cr-Commit-Position: refs/heads/master@{#330080}