Show the eject button only for removabled and file handlers.

chrome/browser/chromeos/file_manager/volume_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_FILE_MANAGER_VOLUME_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_FILE_MANAGER_VOLUME_MANAGER_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 48 matching lines @@
 
 // Says how was the mount performed, whether due to user interaction, or
 // automatic. User interaction includes both hardware (pluggins a USB stick)
 // or software (mounting a ZIP archive) interaction.
 enum MountContext {
   MOUNT_CONTEXT_USER,
   MOUNT_CONTEXT_AUTO,
   MOUNT_CONTEXT_UNKNOWN
 };
 
+// Source of a volume's data.
+enum Source { SOURCE_FILE, SOURCE_DEVICE, SOURCE_NETWORK, SOURCE_SYSTEM };
+
 // Represents a volume (mount point) in the volume manager. Validity of the data
 // is guaranteed by the weak pointer. Simply saying, the weak pointer should be
 // valid as long as the volume is mounted.
 class Volume : public base::SupportsWeakPtr<Volume> {
  public:
   ~Volume();
 
   // Factory static methods for different volume types.
   static Volume* CreateForDrive(Profile* profile);
   static Volume* CreateForDownloads(const base::FilePath& downloads_path);
@@ skipping 11 matching lines @@
                                   VolumeType volume_type,
                                   chromeos::DeviceType device_type,
                                   bool read_only);
   static Volume* CreateForTesting(const base::FilePath& device_path,
                                   const base::FilePath& mount_path);
 
   // Getters for all members. See below for details.
   const std::string& volume_id() const { return volume_id_; }
   const std::string& file_system_id() const { return file_system_id_; }
   const std::string& extension_id() const { return extension_id_; }
+  const Source source() const { return source_; }

[hirono, 2015/05/15 08:27:45]

nit for return type: const Source -> Source ?

[mtomasz, 2015/05/15 09:32:37]

Done.

   VolumeType type() const { return type_; }
   chromeos::DeviceType device_type() const { return device_type_; }
   const base::FilePath& source_path() const { return source_path_; }
   const base::FilePath& mount_path() const { return mount_path_; }
   chromeos::disks::MountCondition mount_condition() const {
     return mount_condition_;
   }
   MountContext mount_context() const { return mount_context_; }
   const base::FilePath& system_path_prefix() const {
     return system_path_prefix_;
   }
   const std::string& volume_label() const { return volume_label_; }
   bool is_parent() const { return is_parent_; }
   bool is_read_only() const { return is_read_only_; }
   bool has_media() const { return has_media_; }
+  bool configurable() const { return configurable_; }
 
  private:
   Volume();
 
   // The ID of the volume.
   std::string volume_id_;
 
   // The ID for provided file systems. If other type, then empty string. Unique
   // per providing extension.
   std::string file_system_id_;
 
   // The ID of an extension providing the file system. If other type, then equal
   // to an empty string.
   std::string extension_id_;
 
+  // The source of the volume's data.
+  Source source_;
+
   // The type of mounted volume.
   VolumeType type_;
 
   // The type of device. (e.g. USB, SD card, DVD etc.)
   chromeos::DeviceType device_type_;
 
   // The source path of the volume.
   // E.g.:
   // - /home/chronos/user/Downloads/zipfile_path.zip
   base::FilePath source_path_;
@@ skipping 23 matching lines @@
 
   // Is the device is a parent device (i.e. sdb rather than sdb1).
   bool is_parent_;
 
   // True if the volume is read only.
   bool is_read_only_;
 
   // True if the volume contains media.
   bool has_media_;
 
+  // True if the volume is configurable.
+  bool configurable_;
+
   DISALLOW_COPY_AND_ASSIGN(Volume);
 };
 
 // Manages "Volume"s for file manager. Here are "Volume"s.
 // - Drive File System (not yet supported).
 // - Downloads directory.
 // - Removable disks (volume will be created for each partition, not only one
 //   for a device).
 // - Mounted zip archives.
 class VolumeManager : public KeyedService,
@@ skipping 38 matching lines @@
   // |path| with DOWNLOADS type, and adds its volume info.
   bool RegisterDownloadsDirectoryForTesting(const base::FilePath& path);
 
   // For testing purpose, adds a volume info pointing to |path|, with TESTING
   // type. Assumes that the mount point is already registered.
   void AddVolumeForTesting(const base::FilePath& path,
                            VolumeType volume_type,
                            chromeos::DeviceType device_type,
                            bool read_only);
 
+  // For testing purpose, adds the volume info to the volume manager.
+  void AddVolumeForTesting(linked_ptr<Volume> volume);

[hirono, 2015/05/15 08:27:45]

nit: const linked_ptr<Volume>& volume ?

[mtomasz, 2015/05/15 09:32:37]

I was considering it, but it seemed that linked_ptr via value is more often used
(2x more). I guess it's because they are very small (2 pointers) of data.
However, it seems reasonable to use a reference instead. Done.

+
   // drive::DriveIntegrationServiceObserver overrides.
   void OnFileSystemMounted() override;
   void OnFileSystemBeingUnmounted() override;
 
   // chromeos::disks::DiskMountManager::Observer overrides.
   void OnDiskEvent(
       chromeos::disks::DiskMountManager::DiskEvent event,
       const chromeos::disks::DiskMountManager::Disk* disk) override;
   void OnDeviceEvent(chromeos::disks::DiskMountManager::DeviceEvent event,
                      const std::string& device_path) override;
@@ skipping 46 matching lines @@
 
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<VolumeManager> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(VolumeManager);
 };
 
 }  // namespace file_manager
 
 #endif  // CHROME_BROWSER_CHROMEOS_FILE_MANAGER_VOLUME_MANAGER_H_