Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1137323003: Cleanup: Fix base header include guards. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Fix base header include guards. The header include guards should match the file path from root. These entries were found using a modified version of Eric's fix-include-guards.py script found attached in https://code.google.com/p/chromium/issues/detail?id=435361#c7. BUG=435361 TEST=base_unittests R=danakj@chromium.org Committed: https://crrev.com/a311635161697b6fa55af300614beda7339f6bbd Cr-Commit-Position: refs/heads/master@{#329731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M base/android/java_runtime.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/base64.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/base_paths_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/debug/profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M base/file_version_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/files/dir_reader_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/dir_reader_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/memory_pressure_monitor_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/observer_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/pickle.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/profiler/scoped_profile.h View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_dump_request_args.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/trace_event/trace_event_etw_export_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/tuple.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/win/resource_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/win/startup_information.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 7 months ago (2015-05-13 20:24:43 UTC) #1
danakj
LGTM
5 years, 7 months ago (2015-05-13 20:26:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137323003/1
5 years, 7 months ago (2015-05-13 20:42:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 22:10:25 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 22:11:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a311635161697b6fa55af300614beda7339f6bbd
Cr-Commit-Position: refs/heads/master@{#329731}

Powered by Google App Engine
This is Rietveld 408576698