Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137183004: [Smart Lock] Update strings in chrome://settings/passwords (Closed)

Created:
5 years, 7 months ago by Garrett Casto
Modified:
5 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, gcasto+watchlist_chromium.org, michaelpg+watch-options_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Update strings in chrome://settings/passwords BUG=486739 Committed: https://crrev.com/25f30bbb3c9f6230d86ec37f0eb4e75490208f29 Cr-Commit-Position: refs/heads/master@{#330211}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 2 2 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Garrett Casto
Screenshot at crbug.com/486739#c26
5 years, 7 months ago (2015-05-15 17:48:04 UTC) #2
Evan Stade
lgtm https://codereview.chromium.org/1137183004/diff/1/chrome/browser/ui/webui/options/password_manager_handler.cc File chrome/browser/ui/webui/options/password_manager_handler.cc (right): https://codereview.chromium.org/1137183004/diff/1/chrome/browser/ui/webui/options/password_manager_handler.cc#newcode79 chrome/browser/ui/webui/options/password_manager_handler.cc:79: int title_id = IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE; nit: prefer ternary
5 years, 7 months ago (2015-05-15 18:55:02 UTC) #3
Garrett Casto
https://codereview.chromium.org/1137183004/diff/1/chrome/browser/ui/webui/options/password_manager_handler.cc File chrome/browser/ui/webui/options/password_manager_handler.cc (right): https://codereview.chromium.org/1137183004/diff/1/chrome/browser/ui/webui/options/password_manager_handler.cc#newcode79 chrome/browser/ui/webui/options/password_manager_handler.cc:79: int title_id = IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE; On 2015/05/15 18:55:02, Evan Stade ...
5 years, 7 months ago (2015-05-15 20:43:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137183004/40001
5 years, 7 months ago (2015-05-15 20:45:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-15 22:15:50 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:28:12 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/25f30bbb3c9f6230d86ec37f0eb4e75490208f29
Cr-Commit-Position: refs/heads/master@{#330211}

Powered by Google App Engine
This is Rietveld 408576698