[Smart Lock] Update strings in chrome://settings/passwords

chrome/browser/ui/webui/options/password_manager_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/password_manager_handler.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #if defined(OS_WIN) && defined(USE_ASH)
 #include "chrome/browser/ui/ash/ash_util.h"
 #endif
 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
+#include "chrome/browser/ui/passwords/password_bubble_experiment.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/common/experiments.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
@@ skipping 37 matching lines @@
       IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON },
     { "passwordHideButton",
       IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON },
     { "passwordsNoPasswordsDescription",
       IDS_PASSWORDS_PAGE_VIEW_NO_PASSWORDS_DESCRIPTION },
     { "passwordsNoExceptionsDescription",
       IDS_PASSWORDS_PAGE_VIEW_NO_EXCEPTIONS_DESCRIPTION },
   };
 
   RegisterStrings(localized_strings, resources, arraysize(resources));
-  RegisterTitle(localized_strings, "passwordsPage",
-                IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE);
+
+  int title_id = IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE;

[Evan Stade, 2015/05/15 18:55:02]

nit: prefer ternary

[Garrett Casto, 2015/05/15 20:43:00]

Done.

+  if (password_bubble_experiment::IsSmartLockBrandingEnabled(GetProfile()))
+    title_id = IDS_PASSWORDS_EXCEPTIONS_SMART_LOCK_WINDOW_TITLE;
+  RegisterTitle(localized_strings, "passwordsPage", title_id);
 
   localized_strings->SetString("passwordManagerLearnMoreURL",
                                chrome::kPasswordManagerLearnMoreURL);
   localized_strings->SetString("passwordsManagePasswordsLink",
                                chrome::kPasswordManagerAccountDashboardURL);
 
-  std::vector<base::string16> pieces;
-  base::SplitStringDontTrim(
-      l10n_util::GetStringUTF16(IDS_MANAGE_PASSWORDS_REMOTE_TEXT),
-      '|',  // separator
-      &pieces);
-  DCHECK_EQ(3U, pieces.size());
+  std::string management_hostname =
+      GURL(chrome::kPasswordManagerAccountDashboardURL).host();
+  base::string16 link_text = base::UTF8ToUTF16(management_hostname);
+  size_t offset;
+  base::string16 full_text = l10n_util::GetStringFUTF16(
+      IDS_MANAGE_PASSWORDS_REMOTE_TEXT, link_text, &offset);
+
   localized_strings->SetString("passwordsManagePasswordsBeforeLinkText",
-                               pieces[0]);
-  localized_strings->SetString("passwordsManagePasswordsLinkText", pieces[1]);
+                               full_text.substr(0, offset));
+  localized_strings->SetString("passwordsManagePasswordsLinkText",
+                               full_text.substr(offset,
+                                                offset + link_text.size()));
   localized_strings->SetString("passwordsManagePasswordsAfterLinkText",
-                               pieces[2]);
+                               full_text.substr(offset + link_text.size()));
 
   bool disable_show_passwords = false;
 
 #if defined(OS_WIN) && defined(USE_ASH)
   // We disable the ability to show passwords when running in Windows Metro
   // interface.  This is because we cannot pop native Win32 dialogs from the
   // Metro process.
   // TODO(wfh): Revisit this if Metro usage grows.
   if (chrome::IsNativeWindowInAsh(GetNativeWindow()))
     disable_show_passwords = true;
@@ skipping 115 matching lines @@
   for (size_t i = 0; i < password_exception_list.size(); ++i) {
     entries.AppendString(
         GetHumanReadableOrigin(*password_exception_list[i], languages_));
   }
 
   web_ui()->CallJavascriptFunction("PasswordManager.setPasswordExceptionsList",
                                    entries);
 }
 
 }  // namespace options