New Task Manager - Phase 1.3.1.B: SubframeTask

New Task Manager - Phase 1.3.1.B: SubframeTask

Implement SubframeTask to represent out-of-process iframes.

R=nick@chromium.org
BUG=470988
Committed: https://crrev.com/88afb7e7518d67ead34d90f5bec598dc10193c86
Cr-Commit-Position: refs/heads/master@{#329889}

[afakhry, 2015-05-12 21:00:56]

nick@, Could you please review this CL? Thanks.

[ncarter (slow), 2015-05-13 16:53:19]

lgtm

https://codereview.chromium.org/1137183002/diff/1/chrome/browser/task_managem...
File chrome/browser/task_management/providers/web_contents/subframe_task.cc
(right):

https://codereview.chromium.org/1137183002/diff/1/chrome/browser/task_managem...
chrome/browser/task_management/providers/web_contents/subframe_task.cc:41: void
SubframeTask::OnTitleChanged(content::NavigationEntry* entry) {
May be worth adding a comment here explaining why it's right to do nothing.

Something like this...

  // This will be called when the title changes on the WebContents's main frame,
  // but this Task represents other frames, so we don't care.

https://codereview.chromium.org/1137183002/diff/1/chrome/browser/task_managem...
chrome/browser/task_management/providers/web_contents/subframe_task.cc:44: void
SubframeTask::OnFaviconChanged() {
Same here.

[afakhry, 2015-05-14 17:01:12]

https://codereview.chromium.org/1137183002/diff/1/chrome/browser/task_managem...
File chrome/browser/task_management/providers/web_contents/subframe_task.cc
(right):

https://codereview.chromium.org/1137183002/diff/1/chrome/browser/task_managem...
chrome/browser/task_management/providers/web_contents/subframe_task.cc:41: void
SubframeTask::OnTitleChanged(content::NavigationEntry* entry) {
On 2015/05/13 16:53:18, ncarter wrote:
> May be worth adding a comment here explaining why it's right to do nothing.
> 
> Something like this...
> 
>   // This will be called when the title changes on the WebContents's main
frame,
>   // but this Task represents other frames, so we don't care.

Done.

https://codereview.chromium.org/1137183002/diff/1/chrome/browser/task_managem...
chrome/browser/task_management/providers/web_contents/subframe_task.cc:44: void
SubframeTask::OnFaviconChanged() {
On 2015/05/13 16:53:19, ncarter wrote:
> Same here.

Done.

[ncarter (slow), 2015-05-14 17:22:26]

still lgtm

[afakhry, 2015-05-14 17:28:33]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2015-05-14 17:29:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137183002/20001

[commit-bot: I haz the power, 2015-05-14 19:00:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-14 19:01:32]

Patchset 2 (id:??) landed as
https://crrev.com/88afb7e7518d67ead34d90f5bec598dc10193c86
Cr-Commit-Position: refs/heads/master@{#329889}