New Task Manager - Phase 1.3.1.B: SubframeTask

chrome/browser/task_management/providers/web_contents/subframe_task.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/task_management/providers/web_contents/subframe_task.h"
+
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/grit/generated_resources.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/site_instance.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace task_management {
+
+namespace {
+
+base::string16 AdjustTitle(const content::SiteInstance* site_instance) {
+  DCHECK(site_instance);
+  int message_id = site_instance->GetBrowserContext()->IsOffTheRecord() ?
+      IDS_TASK_MANAGER_SUBFRAME_INCOGNITO_PREFIX :
+      IDS_TASK_MANAGER_SUBFRAME_PREFIX;
+
+  return l10n_util::GetStringFUTF16(message_id, base::UTF8ToUTF16(
+      site_instance->GetSiteURL().spec()));
+}
+
+}  // namespace
+
+SubframeTask::SubframeTask(content::RenderFrameHost* render_frame_host)
+    : RendererTask(AdjustTitle(render_frame_host->GetSiteInstance()),
+                   nullptr,
+                   render_frame_host->GetProcess()->GetHandle(),
+                   render_frame_host->GetProcess()) {
+}
+
+SubframeTask::~SubframeTask() {
+}
+
+void SubframeTask::OnTitleChanged(content::NavigationEntry* entry) {

[ncarter (slow), 2015/05/13 16:53:18]

May be worth adding a comment here explaining why it's right to do nothing.

Something like this...

  // This will be called when the title changes on the WebContents's main frame,
  // but this Task represents other frames, so we don't care.

[afakhry, 2015/05/14 17:01:12]

Done.

+}
+
+void SubframeTask::OnFaviconChanged() {

[ncarter (slow), 2015/05/13 16:53:19]

Same here.

[afakhry, 2015/05/14 17:01:12]

Done.

+}
+
+}  // namespace task_management