Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1137113002: Fix flakiness in WebstoreProviderTest. (Closed)

Created:
5 years, 7 months ago by Matt Giuca
Modified:
5 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@applist-webstore-highlight
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness in WebstoreProviderTest. The |mock_server_response_| field was being set in parallel with actually running the query, so there was a race condition if the network request came in before the response field is set. Now sets the |mock_server_response_| before starting the query. BUG=246136 Committed: https://crrev.com/9fd6daec4a1cee3f12740ce48c40d647f36c983a Cr-Commit-Position: refs/heads/master@{#329364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Matt Giuca
So confident that I'm titling this CL "Fix flakiness". (I'll still keep an eye on ...
5 years, 7 months ago (2015-05-12 05:37:54 UTC) #2
xiyuan
LGTM Awesome. :)
5 years, 7 months ago (2015-05-12 05:43:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137113002/1
5 years, 7 months ago (2015-05-12 05:58:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 06:39:28 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 06:40:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fd6daec4a1cee3f12740ce48c40d647f36c983a
Cr-Commit-Position: refs/heads/master@{#329364}

Powered by Google App Engine
This is Rietveld 408576698