Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc

Issue 1137113002: Fix flakiness in WebstoreProviderTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@applist-webstore-highlight
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
diff --git a/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc b/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
index 22dfef9fa15d4a5ae364ff0897a18f6fc534b68a..e8160aa26c4f4d2874ffa1061e15b4ea178a4a7d 100644
--- a/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
+++ b/chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc
@@ -162,11 +162,10 @@ class WebstoreProviderTest : public InProcessBrowserTest {
void RunQuery(const std::string& query,
const std::string& mock_server_response) {
+ mock_server_response_ = mock_server_response;
webstore_provider_->Start(false, base::UTF8ToUTF16(query));
if (webstore_provider_->query_pending_ && !mock_server_response.empty()) {
- mock_server_response_ = mock_server_response;
-
DCHECK(!run_loop_);
run_loop_.reset(new base::RunLoop);
run_loop_->Run();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698