Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137093002: Remove GrGLVertexArray from GrGpuResource hierarchy. (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrGLVertexArray from GrGpuResource hierarchy. Committed: https://skia.googlesource.com/skia/+/8780bc65bd5a53a38ac4b0a53a5fb283e066ec40

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -46 lines) Patch
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.h View 1 3 chunks +4 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 1 2 chunks +9 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bsalomon
5 years, 7 months ago (2015-05-11 22:17:29 UTC) #2
joshualitt
On 2015/05/11 22:17:29, bsalomon wrote: lgtm + mega pedantic nit
5 years, 7 months ago (2015-05-12 13:58:07 UTC) #3
joshualitt
https://codereview.chromium.org/1137093002/diff/1/src/gpu/gl/GrGLVertexArray.h File src/gpu/gl/GrGLVertexArray.h (right): https://codereview.chromium.org/1137093002/diff/1/src/gpu/gl/GrGLVertexArray.h#newcode11 src/gpu/gl/GrGLVertexArray.h:11: #include "SkTArray.h" Nit, but don't we usually put these ...
5 years, 7 months ago (2015-05-12 13:58:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137093002/40001
5 years, 7 months ago (2015-05-13 16:49:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://skia.googlesource.com/skia/+/8780bc65bd5a53a38ac4b0a53a5fb283e066ec40
5 years, 7 months ago (2015-05-13 16:56:43 UTC) #9
bsalomon
5 years, 7 months ago (2015-05-14 19:49:18 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1137093002/diff/1/src/gpu/gl/GrGLVertexArray.h
File src/gpu/gl/GrGLVertexArray.h (right):

https://codereview.chromium.org/1137093002/diff/1/src/gpu/gl/GrGLVertexArray....
src/gpu/gl/GrGLVertexArray.h:11: #include "SkTArray.h"
On 2015/05/12 13:58:14, joshualitt wrote:
> Nit, but don't we usually put these in alphabetical-esque order? 

Done.

Powered by Google App Engine
This is Rietveld 408576698