Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1136953014: nacl_io: Remove the direct syscall intercept for 'remove' (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, bradnelson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nacl_io: Remove the direct syscall intercept for 'remove' This is no longer needed as the underlying syscalls unlink/rmdir and both intercepted at the IRT level. I believe this was overlooked when we fixed: https://code.google.com/p/nativeclient/issues/detail?id=3709 This should fix the recent lua5.2 failures on the naclports waterfall. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk BUG=487701 Committed: https://crrev.com/c7f1b7b5fa91ad0421e3a358dc7f6bb3aaafbe23 Cr-Commit-Position: refs/heads/master@{#329871}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -23 lines) Patch
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/remove.c View 1 chunk +0 lines, -17 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Sam Clegg
5 years, 7 months ago (2015-05-13 19:12:18 UTC) #2
binji
Could you add a link to the CL where unlink and rmdir were added, to ...
5 years, 7 months ago (2015-05-13 21:28:41 UTC) #3
Sam Clegg
On 2015/05/13 21:28:41, binji wrote: > Could you add a link to the CL where ...
5 years, 7 months ago (2015-05-13 21:36:52 UTC) #4
Sam Clegg
5 years, 7 months ago (2015-05-13 21:37:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136953014/20001
5 years, 7 months ago (2015-05-14 17:29:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 17:38:56 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 17:40:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7f1b7b5fa91ad0421e3a358dc7f6bb3aaafbe23
Cr-Commit-Position: refs/heads/master@{#329871}

Powered by Google App Engine
This is Rietveld 408576698