native_client_sdk/src/libraries/nacl_io/syscalls/remove.c - Issue 1136953014: nacl_io: Remove the direct syscall intercept for 'remove'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/syscalls/remove.c

Issue 1136953014: nacl_io: Remove the direct syscall intercept for 'remove' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/library.dsc ('k') | native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/libraries/nacl_io/syscalls/remove.c

diff --git a/native_client_sdk/src/libraries/nacl_io/syscalls/remove.c b/native_client_sdk/src/libraries/nacl_io/syscalls/remove.c

deleted file mode 100644

index 317b9f10dc90df00a86265ef3f40012a5f5be46d..0000000000000000000000000000000000000000

--- a/native_client_sdk/src/libraries/nacl_io/syscalls/remove.c

+++ /dev/null

@@ -1,17 +0,0 @@

- * Use of this source code is governed by a BSD-style license that can be

- * found in the LICENSE file. */

-#include "nacl_io/kernel_intercept.h"

-#include "nacl_io/kernel_wrap.h"

-#if defined(__GLIBC__) && defined(__native_client__)

-// Glibc's remove(3) and unlink(2) entry points are not yet hooked up

-// to the lower level IRT interfaces. Therefore the only way to intercept

-// these calls is to override them here.

-// TODO(sbc): remove this once glibc plumbing is in place for remove/unlink

-int remove(const char* path) {

- return ki_remove(path);

-#endif