Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: chrome/browser/chromeos/login/user_manager_impl.cc

Issue 11369258: Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_manager_impl.cc
===================================================================
--- chrome/browser/chromeos/login/user_manager_impl.cc (revision 167824)
+++ chrome/browser/chromeos/login/user_manager_impl.cc (working copy)
@@ -174,13 +174,13 @@
prefs_users_update->Clear();
// Make sure this user is first.
- prefs_users_update->Append(new base::StringValue(email));
+ prefs_users_update->Append(Value::CreateStringValue(email));
UserList::iterator logged_in_user = users_.end();
for (UserList::iterator it = users_.begin(); it != users_.end(); ++it) {
std::string user_email = (*it)->email();
// Skip the most recent user.
if (email != user_email)
- prefs_users_update->Append(new base::StringValue(user_email));
+ prefs_users_update->Append(Value::CreateStringValue(user_email));
else
logged_in_user = it;
}
@@ -369,7 +369,7 @@
DictionaryPrefUpdate display_name_update(local_state, kUserDisplayName);
display_name_update->SetWithoutPathExpansion(
username,
- new base::StringValue(display_name));
+ base::Value::CreateStringValue(display_name));
}
string16 UserManagerImpl::GetUserDisplayName(
@@ -397,7 +397,7 @@
DictionaryPrefUpdate display_email_update(local_state, kUserDisplayEmail);
display_email_update->SetWithoutPathExpansion(
username,
- new base::StringValue(display_email));
+ base::Value::CreateStringValue(display_email));
}
std::string UserManagerImpl::GetUserDisplayEmail(
@@ -729,7 +729,7 @@
std::string user_email = (*it)->email();
// Skip user that we would like to delete.
if (email != user_email)
- prefs_users_update->Append(new base::StringValue(user_email));
+ prefs_users_update->Append(Value::CreateStringValue(user_email));
else
user_to_remove = it;
}

Powered by Google App Engine
This is Rietveld 408576698