Issue 11369144: ui: Make gfx::Point::Scale() mutate the class, similar to gfx::Rect.

Issue 11369144: ui: Make gfx::Point::Scale() mutate the class, similar to gfx::Rect. (Closed)

Created:
8 years, 1 month ago by danakj

Modified:
8 years, 1 month ago

Reviewers:
jamesr, sky, tfarina

CC:
chromium-reviews, jonathan.backer, Ian Vollick, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui: Make gfx::Point::Scale() mutate the class, similar to gfx::Rect. We add gfx::ScalePoint() as a non-mutating version of the Scale method. Tests: ui_unittests:PointTest.Scale R=sky BUG=160158 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166979

Patch Set 1 #

Patch Set 2 : Fixes for aura #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -52 lines)			Patch
M	ash/touch/touch_uma.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/layer_impl.cc	View		1 chunk	+1 line, -1 line	2 comments	Download
M	cc/layer_tree_host_impl.cc	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	content/browser/renderer_host/dip_util.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	ui/aura/root_window.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/base/x/x11_util.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/compositor/dip_util.cc	View		4 chunks	+5 lines, -6 lines	0 comments	Download
M	ui/gfx/point.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	ui/gfx/point_f.h	View		2 chunks	+10 lines, -4 lines	0 comments	Download
M	ui/gfx/point_f.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	ui/gfx/point_unittest.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	ui/gfx/quad_f.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/gfx/quad_unittest.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/gfx/rect_f.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gfx/shadow_value.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/webcursor_aurax11.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_2d_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/11369144/diff/5001/cc/layer_impl.cc File cc/layer_impl.cc (right): https://codereview.chromium.org/11369144/diff/5001/cc/layer_impl.cc#newcode217 cc/layer_impl.cc:217: gfx::PointF hitTestPointInLayerSpace = gfx::ScalePoint(hitTestPointInContentSpace, 1 / contentsScaleX(), 1 ...

8 years, 1 month ago (2012-11-09 16:54:53 UTC) #2

danakj

https://codereview.chromium.org/11369144/diff/5001/cc/layer_impl.cc File cc/layer_impl.cc (right): https://codereview.chromium.org/11369144/diff/5001/cc/layer_impl.cc#newcode217 cc/layer_impl.cc:217: gfx::PointF hitTestPointInLayerSpace = gfx::ScalePoint(hitTestPointInContentSpace, 1 / contentsScaleX(), 1 / ...

8 years, 1 month ago (2012-11-09 17:04:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11369144/5001

8 years, 1 month ago (2012-11-09 18:27:12 UTC) #6

tfarina

8 years, 1 month ago (2012-11-09 18:43:10 UTC) #7

On Friday, November 9, 2012, wrote:

> LGTM
>
>
>
https://codereview.chromium.**org/11369144/diff/5001/cc/**layer_impl.cc<https...
> File cc/layer_impl.cc (right):
>
> https://codereview.chromium.**org/11369144/diff/5001/cc/**
>
layer_impl.cc#newcode217<https://codereview.chromium.org/11369144/diff/5001/cc/layer_impl.cc#newcode217>
> cc/layer_impl.cc:217: gfx::PointF hitTestPointInLayerSpace =
> gfx::ScalePoint(**hitTestPointInContentSpace, 1 / contentsScaleX(), 1 /
> contentsScaleY());
> Dare I ask, how come the code in cc isn't following the chrome style
> guide?
>
> Because it was imported/copied from the WebKit repository. We are in the
process of fixing this and make it conform with Chromium/Google c++ style
guide.

https://codereview.chromium.**org/11369144/<https://codereview.chromium.org/1...
>
> --
>
>
>

-- 
Thiago

Expand Messages | Collapse Messages