Chromium Code Reviews
Help | Chromium Project | Sign in
(90)

Issue 11369135: Object.observe: notify when element addition causes array growth (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by adamk
Modified:
2 years, 6 months ago
Reviewers:
rafaelw, rossberg
CC:
v8-dev, rafaelw
Visibility:
Public.

Description

Object.observe: notify when element addition causes array growth Committed: https://code.google.com/p/v8/source/detail?r=12914

Patch Set 1 #

Total comments: 4

Patch Set 2 : After review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M src/objects.cc View 1 3 chunks +12 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 1 chunk +22 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
adamk
2 years, 6 months ago (2012-11-08 16:39:16 UTC) #1
rossberg
Looks good so far, but I think you need to look for other code paths ...
2 years, 6 months ago (2012-11-08 16:50:19 UTC) #2
adamk
Added test cases with defineProperty (both accessor and data properties). Also reversed ordering to match ...
2 years, 6 months ago (2012-11-08 17:08:17 UTC) #3
rafaelw
lgtm
2 years, 6 months ago (2012-11-09 10:06:27 UTC) #4
rossberg
2 years, 6 months ago (2012-11-09 10:51:42 UTC) #5
LGTM, landing...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be