Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1136913002: bluetooth: Rename to WebBluetooth in preparation for new WebBluetooth flag. (Closed)

Created:
5 years, 7 months ago by ortuno
Modified:
5 years, 7 months ago
Reviewers:
scheib, pdr., esprehn
CC:
blink-reviews, dglazkov+blink, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Rename to WebBluetooth in preparation for new WebBluetooth flag. Rename Bluetooth to WebBluetooth and add the necessary functions to RunTimeFeatures to support a new Web Bluetooth Flag. This is the blink side patch to introduce the WebBluetooth Flag: [1] This patch. [2] https://codereview.chromium.org/1134473003 [3] https://codereview.chromium.org/1127313004 BUG=486456 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195761

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment by scheib #

Patch Set 3 : Move flag to test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M Source/modules/bluetooth/Bluetooth.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothDevice.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothDiscovery.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothGATTRemoteServer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothGATTService.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothInteraction.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothUUIDs.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/BluetoothUUIDsService.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/bluetooth/NavigatorBluetooth.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 2 chunks +1 line, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
ortuno
@scheib: PTAL
5 years, 7 months ago (2015-05-10 02:32:16 UTC) #2
scheib
LGTM https://codereview.chromium.org/1136913002/diff/1/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/1136913002/diff/1/Source/platform/RuntimeEnabledFeatures.in#newcode30 Source/platform/RuntimeEnabledFeatures.in:30: // TODO(ortuno): Remove status=experimental once patch on browser ...
5 years, 7 months ago (2015-05-12 17:51:36 UTC) #3
ortuno
https://codereview.chromium.org/1136913002/diff/1/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/1136913002/diff/1/Source/platform/RuntimeEnabledFeatures.in#newcode30 Source/platform/RuntimeEnabledFeatures.in:30: // TODO(ortuno): Remove status=experimental once patch on browser side ...
5 years, 7 months ago (2015-05-12 19:52:49 UTC) #4
ortuno
@esprehn: Please owners review for WebRuntimeFeatures.h and RuntimeEnabledFeatures.*
5 years, 7 months ago (2015-05-12 19:54:00 UTC) #6
ortuno
On 2015/05/12 at 19:54:00, ortuno wrote: > @esprehn: Please owners review for WebRuntimeFeatures.h and RuntimeEnabledFeatures.* ...
5 years, 7 months ago (2015-05-15 23:03:30 UTC) #7
esprehn
On 2015/05/15 at 23:03:30, ortuno wrote: > On 2015/05/12 at 19:54:00, ortuno wrote: > > ...
5 years, 7 months ago (2015-05-16 05:53:23 UTC) #8
scheib
On 2015/05/16 05:53:23, esprehn wrote: > On 2015/05/15 at 23:03:30, ortuno wrote: > > On ...
5 years, 7 months ago (2015-05-16 20:16:08 UTC) #9
ortuno
@japhet: please OWNERS review for public/web/WebRuntimeFeatures.h
5 years, 7 months ago (2015-05-19 19:23:06 UTC) #11
ortuno
@pdr: japhet is OOO. PTAL at public/web/WebRuntimeFeatures.h
5 years, 7 months ago (2015-05-21 18:03:00 UTC) #13
pdr.
On 2015/05/21 at 18:03:00, ortuno wrote: > @pdr: japhet is OOO. PTAL at public/web/WebRuntimeFeatures.h LGTM
5 years, 7 months ago (2015-05-22 05:10:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136913002/40001
5 years, 7 months ago (2015-05-22 05:11:20 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 05:15:10 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195761

Powered by Google App Engine
This is Rietveld 408576698