Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1127313004: bluetooth: Remove from test flags (Closed)

Created:
5 years, 7 months ago by ortuno
Modified:
5 years, 6 months ago
Reviewers:
scheib, pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@bluetooth-own-flag
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Remove from test flags Since we add the flag manually to the command line flags, there is no point in marking the flag as a test flag. This is the last patch to introduce the WebBluetooth Flag: [1] https://codereview.chromium.org/1136913002 [2] https://codereview.chromium.org/1134473003 [3] This patch. BUG=486456 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195825

Patch Set 1 #

Patch Set 2 : Merged with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
scheib
LGTM
5 years, 7 months ago (2015-05-12 17:52:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313004/1
5 years, 7 months ago (2015-05-22 21:55:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/45318) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 7 months ago (2015-05-22 21:59:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313004/20001
5 years, 7 months ago (2015-05-22 22:23:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/33721)
5 years, 7 months ago (2015-05-22 22:29:39 UTC) #11
ortuno
@pdr: One line change PTAL.
5 years, 7 months ago (2015-05-22 22:35:34 UTC) #13
pdr.
On 2015/05/22 at 22:35:34, ortuno wrote: > @pdr: One line change PTAL. Just to be ...
5 years, 7 months ago (2015-05-22 23:52:38 UTC) #14
ortuno
On 2015/05/22 at 23:52:38, pdr wrote: > On 2015/05/22 at 22:35:34, ortuno wrote: > > ...
5 years, 7 months ago (2015-05-23 00:09:26 UTC) #15
pdr.
On 2015/05/23 at 00:09:26, ortuno wrote: > On 2015/05/22 at 23:52:38, pdr wrote: > > ...
5 years, 7 months ago (2015-05-23 00:42:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313004/20001
5 years, 7 months ago (2015-05-23 00:43:30 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-23 06:23:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195825

Powered by Google App Engine
This is Rietveld 408576698