|
|
Chromium Code Reviews
Descriptionbluetooth: Remove from test flags
Since we add the flag manually to the command line flags, there is no point
in marking the flag as a test flag.
This is the last patch to introduce the WebBluetooth Flag:
[1] https://codereview.chromium.org/1136913002
[2] https://codereview.chromium.org/1134473003
[3] This patch.
BUG=486456
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195825
Patch Set 1 #Patch Set 2 : Merged with TOT #Messages
Total messages: 19 (8 generated)
scheib@chromium.org changed reviewers: + scheib@chromium.org
LGTM
The CQ bit was checked by ortuno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...) mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/56193)
The CQ bit was checked by ortuno@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org Link to the patchset: https://codereview.chromium.org/1127313004/#ps20001 (title: "Merged with TOT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)
ortuno@chromium.org changed reviewers: + pdr@chromium.org
@pdr: One line change PTAL.
On 2015/05/22 at 22:35:34, ortuno wrote: > @pdr: One line change PTAL. Just to be explicit: this isn't shipping any new functionality, only updating flags? If so, LGTM. If not, please explain more :)
On 2015/05/22 at 23:52:38, pdr wrote: > On 2015/05/22 at 22:35:34, ortuno wrote: > > @pdr: One line change PTAL. > > Just to be explicit: this isn't shipping any new functionality, only updating flags? If so, LGTM. If not, please explain more :) You might want to look at the issue for more context: http://crbug.com/486456 But yes, this change only updates the flag. I accidentally added the status=test part in the previous CL and this change removes it. Since we are manually adding the flag during layout tests there is no need to have "status=test"
On 2015/05/23 at 00:09:26, ortuno wrote: > On 2015/05/22 at 23:52:38, pdr wrote: > > On 2015/05/22 at 22:35:34, ortuno wrote: > > > @pdr: One line change PTAL. > > > > Just to be explicit: this isn't shipping any new functionality, only updating flags? If so, LGTM. If not, please explain more :) > > You might want to look at the issue for more context: http://crbug.com/486456 > > But yes, this change only updates the flag. I accidentally added the status=test part in the previous CL and this change removes it. Since we are manually adding the flag during layout tests there is no need to have "status=test" LGTM :)
The CQ bit was checked by ortuno@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=195825 |
