Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java

Issue 11369129: Issue 6463. Remove support for obsolete metadata in comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
index 8e46da100b051310153f0ad1d8f590e96972fa35..25613afcd930d4db6224a7079a6ddd45e9226c37 100644
--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
@@ -1635,16 +1635,17 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
public void test_metadataCommentOverride_Bad_method() throws Exception {
AnalyzeLibraryResult result = analyzeLibrary(
"// filler filler filler filler filler filler filler filler filler filler",
+ "const override = 0;",
"class A {",
"}",
"class B extends A {",
- " // @override",
+ " @override",
" foo() {}",
"}",
"");
assertErrors(
result.getErrors(),
- errEx(ResolverErrorCode.INVALID_OVERRIDE_METADATA, 6, 3, 3));
+ errEx(ResolverErrorCode.INVALID_OVERRIDE_METADATA, 7, 3, 3));
}
public void testImplementsAndOverrides5() throws Exception {
@@ -3689,14 +3690,14 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
public void test_metadataComment_deprecated_1() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"// filler filler filler filler filler filler filler filler filler filler",
- "// @deprecated",
+ "const deprecated = 0;",
+ "@deprecated",
"ttt() {}",
"class A {",
- " // @deprecated",
- " var fff;",
- " // @deprecated",
+ " var @deprecated fff;",
+ " @deprecated",
" mmmm() {}",
- " // @deprecated",
+ " @deprecated",
" operator + (other) {}",
"}",
"method() {",
@@ -3718,10 +3719,11 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
public void test_metadataComment_deprecated_2() throws Exception {
AnalyzeLibraryResult libraryResult = analyzeLibrary(
"// filler filler filler filler filler filler filler filler filler filler",
- "// @deprecated",
+ "const deprecated = 0;",
+ "@deprecated",
"class A {",
" A.named() {}",
- " // @deprecated",
+ " @deprecated",
" A.depreca() {}",
"}",
"method() {",
@@ -3731,9 +3733,9 @@ public class TypeAnalyzerCompilerTest extends CompilerTestCase {
"");
assertErrors(
libraryResult.getErrors(),
- errEx(TypeErrorCode.DEPRECATED_ELEMENT, 9, 7, 1),
errEx(TypeErrorCode.DEPRECATED_ELEMENT, 10, 7, 1),
- errEx(TypeErrorCode.DEPRECATED_ELEMENT, 10, 9, 7));
+ errEx(TypeErrorCode.DEPRECATED_ELEMENT, 11, 7, 1),
+ errEx(TypeErrorCode.DEPRECATED_ELEMENT, 11, 9, 7));
}
public void test_metadata_resolving() throws Exception {
« no previous file with comments | « compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698