Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java

Issue 11369129: Issue 6463. Remove support for obsolete metadata in comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java b/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java
index f977713fa14adbe3192780cfc40dc772f893b206..5b4ab919fcf3fd88805102ca36d7190e31d05e6e 100644
--- a/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java
+++ b/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java
@@ -1199,34 +1199,6 @@ public class SyntaxTest extends AbstractParserTest {
}
}
- public void test_metadata_deprecated_obsolete() {
- String code = makeCode(
- "// filler filler filler filler filler filler filler filler filler filler",
- "class A {",
- " m0() {}",
- " // @deprecated",
- " m1() {}",
- "}",
- "");
- DartUnit unit = parseUnit(getName() + ".dart", code);
- // A
- {
- DartClass classA = (DartClass) unit.getTopLevelNodes().get(0);
- // m0()
- {
- DartMethodDefinition method = (DartMethodDefinition) classA.getMembers().get(0);
- assertEquals("m0", method.getName().toSource());
- assertEquals(false, method.getObsoleteMetadata().isDeprecated());
- }
- // m1()
- {
- DartMethodDefinition method = (DartMethodDefinition) classA.getMembers().get(1);
- assertEquals("m1", method.getName().toSource());
- assertEquals(true, method.getObsoleteMetadata().isDeprecated());
- }
- }
- }
-
public void test_metadata_override() {
String code = makeCode(
"class A {",
@@ -1284,68 +1256,6 @@ public class SyntaxTest extends AbstractParserTest {
}
}
- public void test_metadata_override_obsolete() {
- String code = makeCode(
- "// filler filler filler filler filler filler filler filler filler filler",
- "class A {",
- " m0() {}",
- " // @override",
- " m1() {}",
- " /** Leading DartDoc comment */",
- " // @override",
- " m2() {}",
- " /**",
- " * DartDoc comment",
- " * @override",
- " */",
- " m3() {}",
- "}",
- "");
- DartUnit unit = parseUnit(getName() + ".dart", code);
- // A
- {
- DartClass classA = (DartClass) unit.getTopLevelNodes().get(0);
- // m0()
- {
- DartMethodDefinition method = (DartMethodDefinition) classA.getMembers().get(0);
- assertEquals("m0", method.getName().toSource());
- assertEquals(false, method.getObsoleteMetadata().isOverride());
- assertNull(method.getDartDoc());
- }
- // m1()
- {
- DartMethodDefinition method = (DartMethodDefinition) classA.getMembers().get(1);
- assertEquals("m1", method.getName().toSource());
- assertEquals(true, method.getObsoleteMetadata().isOverride());
- assertNull(method.getDartDoc());
- }
- // m2()
- {
- DartMethodDefinition method = (DartMethodDefinition) classA.getMembers().get(2);
- assertEquals("m2", method.getName().toSource());
- assertEquals(true, method.getObsoleteMetadata().isOverride());
- {
- DartComment dartDoc = method.getDartDoc();
- assertNotNull(dartDoc);
- assertEquals("/** Leading DartDoc comment */", getNodeSource(code, dartDoc));
- }
- }
- // m3()
- {
- DartMethodDefinition method = (DartMethodDefinition) classA.getMembers().get(3);
- assertEquals("m3", method.getName().toSource());
- assertEquals(true, method.getObsoleteMetadata().isOverride());
- {
- DartComment dartDoc = method.getDartDoc();
- assertNotNull(dartDoc);
- String commentCode = getNodeSource(code, dartDoc);
- assertTrue(commentCode.contains("DartDoc comment"));
- assertTrue(commentCode.contains("@override"));
- }
- }
- }
- }
-
public void test_operators_valid() throws Exception {
parseUnit("operators.dart",
Joiner.on("\n").join(

Powered by Google App Engine
This is Rietveld 408576698