Issue 11369103: Compare SkRegion and android::Region performance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11369103: Compare SkRegion and android::Region performance. (Closed)

Created:
8 years, 1 month ago by danakj

Modified:
7 years, 11 months ago

Reviewers:

CC:
chromium-reviews, cc-bugs_chromium.org, backer, piman, aelias_OOO_until_Jul13, jamesr, enne (OOO)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Compare SkRegion and android::Region performance. Make cc::Region optionally wrap android::Region so we can compare. This is NOT INTENDED TO LAND, but for reference only. Built on top of: https://codereview.chromium.org/11366094/ BUG=147395

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1385 lines, -3 lines)			Patch
A	cc/android_region.h	View	1 chunk	+205 lines, -0 lines	0 comments	Download
A	cc/android_region.cc	View	1 chunk	+690 lines, -0 lines	0 comments	Download
A	cc/android_region_helper.h	View	1 chunk	+300 lines, -0 lines	0 comments	Download
M	cc/cc.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/region.h	View	3 chunks	+34 lines, -2 lines	0 comments	Download
M	cc/region.cc	View	2 chunks	+103 lines, -0 lines	0 comments	Download
M	cc/region_unittest.cc	View	1 chunk	+50 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

danakj

8 years, 1 month ago (2012-11-06 20:42:46 UTC) #1

Not for review, just an FYI. Used this to compare SkRegion and android::Region
in the context of occlusion culling.

One thing to note is that android::Region has no "contains()" and intersects()"
query operations. So I had to do this in a less optimal way, however, even
without this SkRegion appears to win.

Expand Messages | Collapse Messages