Chromium Code Reviews
Help | Chromium Project | Sign in
(567)

Issue 11369081: Support shared library build of Android for v8. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by Yaron
Modified:
2 years, 10 months ago
Reviewers:
ulan1, ulan
CC:
v8-dev, cjhopman
Base URL:
http://git.chromium.org/external/v8.git@master
Visibility:
Public.

Description

Support shared library build of Android for v8. v8 depends on the system log library. If we built it as a separate so, log needs to be included in the link step. BUG=chromium:158821 Committed: https://code.google.com/p/v8/source/detail?r=12883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/gyp/v8.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 3 (0 generated)
Yaron
2 years, 10 months ago (2012-11-05 22:57:39 UTC) #1
ulan1
LGTM, I will land it for you.
2 years, 10 months ago (2012-11-07 11:58:57 UTC) #2
ulan
2 years, 10 months ago (2012-11-07 12:21:27 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 020f378