Chromium Code Reviews
Help | Chromium Project | Sign in
(870)

Issue 11369081: Support shared library build of Android for v8. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Yaron_ooo-April_21
Modified:
1 year, 5 months ago
Reviewers:
ulan1, ulan
CC:
v8-dev_googlegroups.com, cjhopman
Base URL:
http://git.chromium.org/external/v8.git@master
Visibility:
Public.

Description

Support shared library build of Android for v8.

v8 depends on the system log library. If we built it as a separate so,
log needs to be included in the link step.

BUG=chromium:158821
Committed: https://code.google.com/p/v8/source/detail?r=12883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Lint Patch
M tools/gyp/v8.gyp View 1 chunk +8 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Yaron_ooo-April_21
1 year, 5 months ago #1
ulan1
LGTM, I will land it for you.
1 year, 5 months ago #2
ulan
1 year, 5 months ago #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6