Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 11369081: Support shared library build of Android for v8. (Closed)

Created:
5 years ago by Yaron
Modified:
5 years ago
Reviewers:
ulan_google, ulan
CC:
v8-dev, cjhopman
Base URL:
http://git.chromium.org/external/v8.git@master
Visibility:
Public.

Description

Support shared library build of Android for v8. v8 depends on the system log library. If we built it as a separate so, log needs to be included in the link step. BUG=chromium:158821 Committed: https://code.google.com/p/v8/source/detail?r=12883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/gyp/v8.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 3 (0 generated)
Yaron
5 years ago (2012-11-05 22:57:39 UTC) #1
ulan_google
LGTM, I will land it for you.
5 years ago (2012-11-07 11:58:57 UTC) #2
ulan
5 years ago (2012-11-07 12:21:27 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld efc10ee0f