Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11369052: Fix FindBugs warnings (Closed)

Created:
8 years, 1 month ago by Sami
Modified:
8 years, 1 month ago
Reviewers:
bulach
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added temporary shim to avoid breaking downstream build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/GoogleLocationSettingsHelperStub.java View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Sami
8 years, 1 month ago (2012-11-02 18:35:48 UTC) #1
bulach
lgtm, thanks!
8 years, 1 month ago (2012-11-05 09:43:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/11369052/1
8 years, 1 month ago (2012-11-05 10:35:12 UTC) #3
Sami
Added a temporary shim to avoid breaking downstream build. PTAL?
8 years, 1 month ago (2012-11-05 11:26:45 UTC) #4
bulach
lgtm, thanks!
8 years, 1 month ago (2012-11-05 11:28:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/11369052/1003
8 years, 1 month ago (2012-11-05 11:29:08 UTC) #6
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 1 month ago (2012-11-05 14:37:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/11369052/1003
8 years, 1 month ago (2012-11-05 14:39:29 UTC) #8
commit-bot: I haz the power
8 years, 1 month ago (2012-11-05 16:39:55 UTC) #9 
Change committed as 165944

Powered by Google App Engine
This is Rietveld 408576698